From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32484 invoked by alias); 10 Mar 2004 17:54:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32460 invoked from network); 10 Mar 2004 17:54:55 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Mar 2004 17:54:55 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i2AHss07001383 for ; Wed, 10 Mar 2004 12:54:54 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i2AHsrM12589 for ; Wed, 10 Mar 2004 12:54:53 -0500 Received: from cygbert.vinschen.de (vpn50-12.rdu.redhat.com [172.16.50.12]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i2AHsqR16883 for ; Wed, 10 Mar 2004 09:54:52 -0800 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 25D59580E2; Wed, 10 Mar 2004 18:54:46 +0100 (CET) Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310175446.GR25204@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> <20040310162011.GA1067@nevyn.them.org> <20040310163416.GP25204@cygbert.vinschen.de> <20040310163716.GA2114@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310163716.GA2114@nevyn.them.org> User-Agent: Mutt/1.4.2i X-RedHat-Spam-Score: -1.524 X-SW-Source: 2004-03/txt/msg00241.txt.bz2 Message-ID: <20040319000900.azrJuz6Yireh0b1FW-8izibrD3JiU2TPPrlXoLwoDjE@z> On Mar 10 11:37, Daniel Jacobowitz wrote: > What's the one symbol with just one underscore? _ZZN9__gnu_cxx27__verbose_terminate_handlerEvE11terminating I have a revised patch to solve the GDB problem. The leading_char is removed right before the call to SYMBOL_SET_NAMES. The same functionality is removed from install_minimal_symbols entirely. I tested on i686-pc-linux with gcc 3.3 and sh-elf with gcc 3.4. The testsuite has 48 less FAILs on sh-elf, all in gdb.cp. The testsuite has one FAIL more for i686-pc-linux: FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1) though I must admit that I don't see what that has to do with my patch. Corinna * minsyms.c (install_minimal_symbols): Move dropping leading char from linkage name from here... (prim_record_minimal_symbol_and_info): ...to here. Index: minsyms.c =================================================================== RCS file: /cvs/src/src/gdb/minsyms.c,v retrieving revision 1.41 diff -u -p -r1.41 minsyms.c --- minsyms.c 9 Feb 2004 19:13:46 -0000 1.41 +++ minsyms.c 10 Mar 2004 17:17:37 -0000 @@ -611,6 +611,8 @@ prim_record_minimal_symbol_and_info (con msymbol = &msym_bunch->contents[msym_bunch_index]; SYMBOL_INIT_LANGUAGE_SPECIFIC (msymbol, language_unknown); SYMBOL_LANGUAGE (msymbol) = language_auto; + if (name[0] == get_symbol_leading_char (objfile->obfd)) + ++name; SYMBOL_SET_NAMES (msymbol, (char *)name, strlen (name), objfile); SYMBOL_VALUE_ADDRESS (msymbol) = address; @@ -864,13 +866,7 @@ install_minimal_symbols (struct objfile for (bunch = msym_bunch; bunch != NULL; bunch = bunch->next) { for (bindex = 0; bindex < msym_bunch_index; bindex++, mcount++) - { - msymbols[mcount] = bunch->contents[bindex]; - if (SYMBOL_LINKAGE_NAME (&msymbols[mcount])[0] == leading_char) - { - SYMBOL_LINKAGE_NAME (&msymbols[mcount])++; - } - } + msymbols[mcount] = bunch->contents[bindex]; msym_bunch_index = BUNCH_SIZE; } -- Corinna Vinschen Cygwin Developer Red Hat, Inc.