From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3808 invoked by alias); 9 Mar 2004 16:41:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3787 invoked from network); 9 Mar 2004 16:41:14 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 9 Mar 2004 16:41:14 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B0kHs-0002ac-RA; Tue, 09 Mar 2004 11:41:00 -0500 Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: Atsushi Nemoto Subject: Re: [patch] Fix handle_inferior_event nostop signal handling for threads Message-ID: <20040309164100.GD27765@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Atsushi Nemoto References: <20040307010654.GA10796@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040307010654.GA10796@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00201.txt.bz2 Message-ID: <20040319000900.TjO_CzyeFFU0tbIRzU4ccy4wbG3G5EoTDrvgsEAa5W0@z> On Sat, Mar 06, 2004 at 08:06:54PM -0500, Daniel Jacobowitz wrote: > Atsushi-san, could you verify that this patch still fixes your problem? > I took a look at the #if 0 block, and that made me look at the surrounding > code; I don't believe that a bit of it is necessary. If we switch "current" > threads in response to this event, then all the following bits of > handle_inferior_event should handle the current thread correctly. > > If this works for you I'll commit it to HEAD. I'm not sure if it's safe for > the branch. No regressions on native i686-linux, and it fixes a quirk that > the previous patch I sent you introduced (we could sometimes fail to print > about a pass/print/nostop signal). > 2004-03-06 Daniel Jacobowitz > > * infrun.c (handle_inferior_event): Remove short-circuit code for > events in a different thread. I've committed this for HEAD after retesting on i686-linux and i686-linux/gdbserver. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer