From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12512 invoked by alias); 5 Mar 2004 02:59:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12497 invoked from network); 5 Mar 2004 02:59:12 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 5 Mar 2004 02:59:12 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Az5YN-0001Sm-QN; Thu, 04 Mar 2004 21:59:11 -0500 Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Daniel Jacobowitz To: "Nathan J. Williams" Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] gdbserver: Detect and return errors reading memory Message-ID: <20040305025911.GB5320@nevyn.them.org> Mail-Followup-To: "Nathan J. Williams" , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00080.txt.bz2 Message-ID: <20040319000900.HqEwEKfhVNOkIo3tFiiEPCUMKEfrGD1tSr8tj0-UxZY@z> On Mon, Mar 01, 2004 at 03:55:54PM -0500, Nathan J. Williams wrote: > > As I promised last week, here is a patch to check for errors reading > memory in gdbserver and propagate that error back to the host gdb. This is OK, thanks very much! Do you have CVS access or shall I commit it? [I think some of the files may also need copyright year updates.] > > - Nathan > > 2004-03-01 Nathan J. Williams > > * linux-low.c (linux_read_memory): Change return type to > int. Check for and return error from ptrace(). > * target.c (read_inferior_memory): Change return type to int. Pass > back return status from the_target->read_memory(). > * target.h (struct target_ops): Adapt *read_memory() prototype. > Update comment. > (read_inferior_memory): Adapt prototype. > * server.c (main): Return an error packet if > read_inferior_memory() returns an error. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer