From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19638 invoked by alias); 2 Mar 2004 16:10:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19623 invoked from network); 2 Mar 2004 16:10:14 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 2 Mar 2004 16:10:14 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DBA0A2B92; Tue, 2 Mar 2004 11:10:09 -0500 (EST) Message-ID: <4044B1E1.1020308@gnu.org> Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Re: [rfa/amd64] Zero fill 32-bit registers References: <403E9BC3.2030807@redhat.com> <200402281046.i1SAkhhe000441@elgar.kettenis.dyndns.org> <4040B0F8.2050803@gnu.org> <200402281734.i1SHYvol017921@elgar.kettenis.dyndns.org> <4040E96F.4010809@gnu.org> <200402282025.i1SKPdRr000430@elgar.kettenis.dyndns.org> <4040FC93.9000100@gnu.org> <200402282155.i1SLtqGg006156@elgar.kettenis.dyndns.org> <404271AE.5000102@gnu.org> <200402292345.i1TNjC4i000914@elgar.kettenis.dyndns.org> In-Reply-To: <200402292345.i1TNjC4i000914@elgar.kettenis.dyndns.org> Content-Type: multipart/mixed; boundary="------------050205020300030407000708" X-SW-Source: 2004-03/txt/msg00026.txt.bz2 Message-ID: <20040319000900.HTg3r58KIZk_spsSjRFXVPnG0cdCZ2P1wqLw4DeUCeI@z> This is a multi-part message in MIME format. --------------050205020300030407000708 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1734 > The segment registers have the same problem, is the attached ok? 6.1? > With it applied I get test results that approach i386. > > 2004-02-29 Andrew Cagney > > * amd64-nat.c (amd64_collect_native_gregset): Zero-extend the > 32-bit segment registers. > > OK. Feel free to add the segment registers to enum i386_regnum and > use <= I386_GS_REGNUM instead of < I386_ST0_REGNUM though. Attatched is what I've committed (mainline and, in two ticks, 6.1). A GDB, with that PC==0 hack to work around the GLIBC problems applied, gets these unexpected failures: FAIL: gdb.base/gcore.exp: where in corefile (pattern 1) FAIL: gdb.base/gcore.exp: corefile restored general registers FAIL: gdb.base/gcore.exp: corefile restored all registers FAIL: gdb.base/gcore.exp: capture_command_output failed on print array_func::local_array. FAIL: gdb.base/gcore.exp: corefile restored stack array FAIL: gdb.base/gcore.exp: corefile restored backtrace FAIL: gdb.base/interrupt.exp: echo data (timeout) FAIL: gdb.base/signals.exp: continue to func1 (probably kernel bug) FAIL: gdb.base/signals.exp: continue to handler (the program exited) FAIL: gdb.threads/gcore-thread.exp: corefile contains at least two threads FAIL: gdb.threads/gcore-thread.exp: a corefile thread is executing thread2 FAIL: gdb.threads/gcore-thread.exp: thread2 is current thread in corefile === gdb Summary === # of expected passes 9860 # of unexpected failures 12 # of unexpected successes 1 # of expected failures 47 # of unknown successes 12 # of known failures 33 # of untested testcases 3 # of unsupported tests 1 not bad, eh :-) Andrew --------------050205020300030407000708 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1587 2004-03-02 Andrew Cagney * i386-tdep.h (enum i386_regnum): Add I386_DS_REGNUM, I386_ES_REGNUM, I386_FS_REGNUM, and I386_GS_REGNUM. Remove trailing comma and redundant assignment of I386_ST0_REGNUM. * amd64-nat.c (amd64_collect_native_gregset): Zero-extend the 32-bit segment registers. Index: amd64-nat.c =================================================================== RCS file: /cvs/src/src/gdb/amd64-nat.c,v retrieving revision 1.5 diff -u -r1.5 amd64-nat.c --- amd64-nat.c 28 Feb 2004 21:55:48 -0000 1.5 +++ amd64-nat.c 2 Mar 2004 15:53:26 -0000 @@ -139,6 +139,12 @@ if (regnum == -1 || regnum == i) memset (regs + amd64_native_gregset_reg_offset (i), 0, 8); } + /* Ditto for %cs, %ss, %ds, %es, %fs, and %gs. */ + for (i = I386_CS_REGNUM; i <= I386_GS_REGNUM; i++) + { + if (regnum == -1 || regnum == i) + memset (regs + amd64_native_gregset_reg_offset (i), 0, 8); + } } if (num_regs > NUM_REGS) Index: i386-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.h,v retrieving revision 1.36 diff -u -r1.36 i386-tdep.h --- i386-tdep.h 22 Feb 2004 11:19:14 -0000 1.36 +++ i386-tdep.h 2 Mar 2004 15:53:26 -0000 @@ -166,7 +166,11 @@ I386_EFLAGS_REGNUM, /* %eflags */ I386_CS_REGNUM, /* %cs */ I386_SS_REGNUM, /* %ss */ - I386_ST0_REGNUM = 16, /* %st(0) */ + I386_DS_REGNUM, /* %ds */ + I386_ES_REGNUM, /* %es */ + I386_FS_REGNUM, /* %fs */ + I386_GS_REGNUM, /* %gs */ + I386_ST0_REGNUM /* %st(0) */ }; #define I386_NUM_GREGS 16 --------------050205020300030407000708--