Re: [PATCH] Cleanup i386-nat.c

Eli Zaretskii
2004-03-04T06:11:18Z

> Date: Wed, 3 Mar 2004 21:30:57 +0100 (CET)
> From: Mark Kettenis <kettenis@chello.nl>
>
> I get the felling I somehow stepped on your toes. I'm sorry for that.
> Although there were some genuine style "problems", my main motivation
> for changing the coding style was the fact that it was mere
> inconsistent with the rest of the i386-specific files in GDB. Since
> I, as the i386 target maintainer feel somehow repsonsible for this
> file, I tried to resolve the inconsistencies. In no way do I blame
> you for those inconsistencies.

Well, no offense, but it surely feels like nitpicking that got out of
proportions. I labored on that code not only to make it right, but
also so that it looks good. Most of those ``style problems'' are
really conscious decisions on my part, meant to make the code
aesthetically pleasant.

I understand that our styles may well be different a bit, but since
GDB is a program maintained by lots of people, it is no surprise that
the code style isn't uniform. I don't see anything wrong with that,
provided that the basic GNU coding conventions are preserved. E.g., I
don't see any need to insist on a specific value of comment-column, or
refill comment blocks, unless they are badly malformed. Do we really
need this kind of ``style police''?

I guess bottom line is, I think that minor style differences shouldn't
be a reason for such extensive changes, especially when an area
maintainer intends to exercise his/her privilege of committing such
changes in someone else's code without any discussion.

Am I the only one who thinks so?