From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17899 invoked by alias); 10 Mar 2004 16:43:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17892 invoked from network); 10 Mar 2004 16:43:44 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Mar 2004 16:43:44 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i2AGhh07006565 for ; Wed, 10 Mar 2004 11:43:43 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i2AGhgM10421 for ; Wed, 10 Mar 2004 11:43:43 -0500 Received: from cygbert.vinschen.de (vpn50-12.rdu.redhat.com [172.16.50.12]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i2AGhfR14278 for ; Wed, 10 Mar 2004 08:43:42 -0800 Received: by cygbert.vinschen.de (Postfix, from userid 500) id B7FCD580E2; Wed, 10 Mar 2004 17:43:35 +0100 (CET) Date: Wed, 10 Mar 2004 16:43:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310164335.GQ25204@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> <20040310162011.GA1067@nevyn.them.org> <20040310163416.GP25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310163416.GP25204@cygbert.vinschen.de> User-Agent: Mutt/1.4.2i X-RedHat-Spam-Score: -4.9 X-SW-Source: 2004-03.o/txt/msg00237.txt On Mar 10 17:34, Corinna Vinschen wrote: > On Mar 10 11:20, Daniel Jacobowitz wrote: > > Move the check earlier? It should not be necessary to change > > SYMBOL_LINKAGE_NAME. I think you could do this in > > prim_record_minimal_symbol_and_info at the call site of > > SYMBOL_SET_NAMES. > > I'm more and more under the impression that the problem is raised due > to a bug in the symbol generation in gcc. It doesn't seem worth to > change GDB proactively... Wait a second. If the symbols actually begin with _Z as they do e.g. on Linux, then the test we're talking about would fail on Linx, too, if... yes, if leading_char would be "_" on Linux as well. But on Linux the leading_char is \0. So, it looks like the actual problem is, that SYMBOL_SET_NAMES is called in prim_record_minimal_symbol_and_info, without having stripped the leading_char from the symbol names. That doesn't explain why there's one symbol which has no leading _ but that would make sense for all other mangled symbols given in the object file, right? Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17899 invoked by alias); 10 Mar 2004 16:43:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17892 invoked from network); 10 Mar 2004 16:43:44 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Mar 2004 16:43:44 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i2AGhh07006565 for ; Wed, 10 Mar 2004 11:43:43 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i2AGhgM10421 for ; Wed, 10 Mar 2004 11:43:43 -0500 Received: from cygbert.vinschen.de (vpn50-12.rdu.redhat.com [172.16.50.12]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i2AGhfR14278 for ; Wed, 10 Mar 2004 08:43:42 -0800 Received: by cygbert.vinschen.de (Postfix, from userid 500) id B7FCD580E2; Wed, 10 Mar 2004 17:43:35 +0100 (CET) Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310164335.GQ25204@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> <20040310162011.GA1067@nevyn.them.org> <20040310163416.GP25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310163416.GP25204@cygbert.vinschen.de> User-Agent: Mutt/1.4.2i X-RedHat-Spam-Score: -4.9 X-SW-Source: 2004-03/txt/msg00237.txt.bz2 Message-ID: <20040319000900.Zjzs87NRV5Ifr2iOsw3hdhZ-Yb2P9bub54aQNlCFK5s@z> On Mar 10 17:34, Corinna Vinschen wrote: > On Mar 10 11:20, Daniel Jacobowitz wrote: > > Move the check earlier? It should not be necessary to change > > SYMBOL_LINKAGE_NAME. I think you could do this in > > prim_record_minimal_symbol_and_info at the call site of > > SYMBOL_SET_NAMES. > > I'm more and more under the impression that the problem is raised due > to a bug in the symbol generation in gcc. It doesn't seem worth to > change GDB proactively... Wait a second. If the symbols actually begin with _Z as they do e.g. on Linux, then the test we're talking about would fail on Linx, too, if... yes, if leading_char would be "_" on Linux as well. But on Linux the leading_char is \0. So, it looks like the actual problem is, that SYMBOL_SET_NAMES is called in prim_record_minimal_symbol_and_info, without having stripped the leading_char from the symbol names. That doesn't explain why there's one symbol which has no leading _ but that would make sense for all other mangled symbols given in the object file, right? Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.