From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5859 invoked by alias); 10 Mar 2004 16:20:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5850 invoked from network); 10 Mar 2004 16:20:11 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 10 Mar 2004 16:20:11 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B16RH-0000Jd-Ik for ; Wed, 10 Mar 2004 11:20:11 -0500 Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310162011.GA1067@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310161617.GO25204@cygbert.vinschen.de> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00234.txt.bz2 On Wed, Mar 10, 2004 at 05:16:17PM +0100, Corinna Vinschen wrote: > On Mar 10 11:04, Daniel Jacobowitz wrote: > > > > to me like you are having a problem with leading underscores, if I > > > > remember my sh-elf-foo correctly. > > > > > > Could you tell more about that? I see a big bunch of symbols beginning > > > with "__Z". Is that what you mean? > > > > Yes, precisely. On sh-elf all symbols are prefixed with an underscore. > > I've been curious for a while about where, precisely, the leading > > underscore is supposed to get stripped before we demangle; apparently, > > the answer is "not early enough". > > Ok, I think I see now what happens. > > There are symbols beginning with "_Z" and (the most) beginning with "__Z". > > The symbols beginning with "_Z" are correctly recognized as language_cplus. > > The symbols beginning with "__Z" are still language_auto after > prim_record_minimal_symbol_and_info has been called, since the demangler > in libiberty doesn't recognize them. Wait a sec, why is that happening? Either everything should have a leading _ or nothing should! > In install_minimal_symbols(), line 864ff is a loop, which strips the > first character from SYMBOL_LINKAGE_NAME, if that character equals > get_symbol_leading_char (objfile->obfd). This leading_char is set > to "_". > > So, after this loop SYMBOL_LINKAGE_NAME begins with "Z" for the first > set of symbols (which *are* recognized as cplus variables) and with > "_Z" for the second set of symbols (which are still auto). But now > SYMBOL_DEMANGLED_NAME is only called for the second set of symbols > and SYMBOL_DEMANGLED_NAME returns NULL for those symbols. > > What can we do?!? Move the check earlier? It should not be necessary to change SYMBOL_LINKAGE_NAME. I think you could do this in prim_record_minimal_symbol_and_info at the call site of SYMBOL_SET_NAMES. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5859 invoked by alias); 10 Mar 2004 16:20:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5850 invoked from network); 10 Mar 2004 16:20:11 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 10 Mar 2004 16:20:11 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B16RH-0000Jd-Ik for ; Wed, 10 Mar 2004 11:20:11 -0500 Date: Wed, 10 Mar 2004 16:20:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310162011.GA1067@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310161617.GO25204@cygbert.vinschen.de> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03.o/txt/msg00234.txt Message-ID: <20040310162000.gpium2CfuTxbBc3yQL73tsu6drzhqDiYQwj1uzwdfeg@z> On Wed, Mar 10, 2004 at 05:16:17PM +0100, Corinna Vinschen wrote: > On Mar 10 11:04, Daniel Jacobowitz wrote: > > > > to me like you are having a problem with leading underscores, if I > > > > remember my sh-elf-foo correctly. > > > > > > Could you tell more about that? I see a big bunch of symbols beginning > > > with "__Z". Is that what you mean? > > > > Yes, precisely. On sh-elf all symbols are prefixed with an underscore. > > I've been curious for a while about where, precisely, the leading > > underscore is supposed to get stripped before we demangle; apparently, > > the answer is "not early enough". > > Ok, I think I see now what happens. > > There are symbols beginning with "_Z" and (the most) beginning with "__Z". > > The symbols beginning with "_Z" are correctly recognized as language_cplus. > > The symbols beginning with "__Z" are still language_auto after > prim_record_minimal_symbol_and_info has been called, since the demangler > in libiberty doesn't recognize them. Wait a sec, why is that happening? Either everything should have a leading _ or nothing should! > In install_minimal_symbols(), line 864ff is a loop, which strips the > first character from SYMBOL_LINKAGE_NAME, if that character equals > get_symbol_leading_char (objfile->obfd). This leading_char is set > to "_". > > So, after this loop SYMBOL_LINKAGE_NAME begins with "Z" for the first > set of symbols (which *are* recognized as cplus variables) and with > "_Z" for the second set of symbols (which are still auto). But now > SYMBOL_DEMANGLED_NAME is only called for the second set of symbols > and SYMBOL_DEMANGLED_NAME returns NULL for those symbols. > > What can we do?!? Move the check earlier? It should not be necessary to change SYMBOL_LINKAGE_NAME. I think you could do this in prim_record_minimal_symbol_and_info at the call site of SYMBOL_SET_NAMES. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer