From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4697 invoked by alias); 9 Mar 2004 20:05:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4690 invoked from network); 9 Mar 2004 20:05:02 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 9 Mar 2004 20:05:02 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B0nTK-0007by-8s for ; Tue, 09 Mar 2004 15:05:02 -0500 Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [ob] user-regs.c build fix for arm-linux Message-ID: <20040309200502.GB18334@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040228173121.GA15679@nevyn.them.org> <4040D178.2050405@gnu.org> <20040228183027.GA17364@nevyn.them.org> <4040E2CC.6010603@gnu.org> <20040229165929.GG15749@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040229165929.GG15749@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00210.txt.bz2 On Sun, Feb 29, 2004 at 11:59:29AM -0500, Daniel Jacobowitz wrote: > On Sat, Feb 28, 2004 at 01:49:48PM -0500, Andrew Cagney wrote: > > >On Sat, Feb 28, 2004 at 12:35:52PM -0500, Andrew Cagney wrote: > > > > > >>>>>+/* We call this gdb_user_regs instead of user_regs to avoid conflicts > > >>>>with > > >>>>>+ any struct user_regs in system headers (for instance, ARM > > >>>>GNU/Linux). >*/ > > >> > > >>> > > >>>Please be more explicit. > > > > > > > > >What else would you like to know? What header it comes from? > > > > Er, yes? The comment should describe the exact cause of the problem. > > Otherwize there is no way to audit this stuff later. > > Is this better? > 2004-02-29 Daniel Jacobowitz > > * user-regs.c: Update copyright years. > (struct user_regs): Rename to gdb_user_regs. > (append_user_reg, builtin_user_regs, user_regs_init) > (user_reg_add, user_reg_map_name_to_regnum) > (usernum_to_user_reg): Update. I've checked this in... > + declares "struc user_regs". */ And fixed the typo in it. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4697 invoked by alias); 9 Mar 2004 20:05:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4690 invoked from network); 9 Mar 2004 20:05:02 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 9 Mar 2004 20:05:02 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B0nTK-0007by-8s for ; Tue, 09 Mar 2004 15:05:02 -0500 Date: Tue, 09 Mar 2004 20:05:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [ob] user-regs.c build fix for arm-linux Message-ID: <20040309200502.GB18334@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040228173121.GA15679@nevyn.them.org> <4040D178.2050405@gnu.org> <20040228183027.GA17364@nevyn.them.org> <4040E2CC.6010603@gnu.org> <20040229165929.GG15749@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040229165929.GG15749@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03.o/txt/msg00210.txt Message-ID: <20040309200500.PXWwlnvnLUajcuJRhtB6DV6oyXm6As1BKPpN3Dr92KY@z> On Sun, Feb 29, 2004 at 11:59:29AM -0500, Daniel Jacobowitz wrote: > On Sat, Feb 28, 2004 at 01:49:48PM -0500, Andrew Cagney wrote: > > >On Sat, Feb 28, 2004 at 12:35:52PM -0500, Andrew Cagney wrote: > > > > > >>>>>+/* We call this gdb_user_regs instead of user_regs to avoid conflicts > > >>>>with > > >>>>>+ any struct user_regs in system headers (for instance, ARM > > >>>>GNU/Linux). >*/ > > >> > > >>> > > >>>Please be more explicit. > > > > > > > > >What else would you like to know? What header it comes from? > > > > Er, yes? The comment should describe the exact cause of the problem. > > Otherwize there is no way to audit this stuff later. > > Is this better? > 2004-02-29 Daniel Jacobowitz > > * user-regs.c: Update copyright years. > (struct user_regs): Rename to gdb_user_regs. > (append_user_reg, builtin_user_regs, user_regs_init) > (user_reg_add, user_reg_map_name_to_regnum) > (usernum_to_user_reg): Update. I've checked this in... > + declares "struc user_regs". */ And fixed the typo in it. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer