Re: [rfa/target/doc] Print less with "set debug target 1"

Andrew Cagney
2004-03-09T00:12:20Z

>>Date: Sat, 6 Mar 2004 18:08:35 -0500
>>> From: Daniel Jacobowitz <drow@false.org>
>>>
>>> Seem OK?
>
>
> Thanks for the documentation patch, but I have 2 minor comments:
>
>
>>> @item set debug target
>>> Turns on or off display of @value{GDBN} target debugging info. This info
>>> includes what is going on at the target level of GDB, as it happens. The
>>> -default is off.
>>> +default is 0. Set it to 1 to track events, and to 2 to also track the
>>> +value of large memory transfers. This flag must be set before connecting
>>> +to the target or saying @code{run}.
>
>
> . I'm not sure I understand this sentence--do you mean to say that
> _if_ the flag is set, it must be set _before_ connecting and
> before "run"? If so, I suggest to use @emph and/or @strong to
> make sure the reader understands you, and maybe rephrase slightly
> to make sure the wording is less ambiguous.
>
> . Since in this context "run" is something the user types, it
> should be @kbd{run}, not @code{run}.

Bad design. This doesn't work:

(gdb) set debug target 1
... do something, get target debug output ...
(gdb) set debug target 0
... do something, no target debug output ...

No technical reason for the behavior (I suspect it is that way 'cos the
target vector is still macros and 'cos people thought that always using
an extra level of indirection would make things slow).

Daniel,

just also file a bug report, and feel free to add some extra verbage to:

add_show_from_set
(add_set_cmd ("target", class_maintenance, var_zinteger,
(char *) &targetdebug,
"Set target debugging.\n\
When non-zero, target debugging is enabled.", &setdebuglist),
&showdebuglist);

Andrew

> Otherwise, it is okay to go in.
>