From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16093 invoked by alias); 8 Mar 2004 22:48:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16068 invoked from network); 8 Mar 2004 22:48:13 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 8 Mar 2004 22:48:13 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i28MmBST026591 for ; Mon, 8 Mar 2004 17:48:12 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i28Mm8M32749; Mon, 8 Mar 2004 17:48:08 -0500 Received: from redhat.com (dhcp-172-16-25-160.sfbay.redhat.com [172.16.25.160]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i28Mm7R08498; Mon, 8 Mar 2004 14:48:07 -0800 Message-ID: <404CF826.8050302@redhat.com> Date: Mon, 08 Mar 2004 22:48:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.4) Gecko/20030922 MIME-Version: 1.0 To: Eli Zaretskii CC: Daniel Jacobowitz , gdb-patches@sources.redhat.com, cagney@gnu.org Subject: Re: [rfa/target/doc] Print less with "set debug target 1" References: <20040306230834.GA9343@nevyn.them.org> <3791-Sun07Mar2004073738+0200-eliz@elta.co.il> In-Reply-To: <3791-Sun07Mar2004073738+0200-eliz@elta.co.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-RedHat-Spam-Score: -4.9 X-SW-Source: 2004-03.o/txt/msg00179.txt Message-ID: <20040308224800.sB8ws4tKRaqP6SJN3BimjkZZXQcalucWPm-_FLIcoo8@z> Eli Zaretskii wrote: >>Date: Sat, 6 Mar 2004 18:08:35 -0500 >>From: Daniel Jacobowitz >> >>Seem OK? > > > Thanks for the documentation patch, but I have 2 minor comments: > > >> @item set debug target >> Turns on or off display of @value{GDBN} target debugging info. This info >> includes what is going on at the target level of GDB, as it happens. The >>-default is off. >>+default is 0. Set it to 1 to track events, and to 2 to also track the >>+value of large memory transfers. This flag must be set before connecting >>+to the target or saying @code{run}. > > > . I'm not sure I understand this sentence--do you mean to say that > _if_ the flag is set, it must be set _before_ connecting and > before "run"? Yeah, that's correct. "set debug target" must be given before the target command. If I remember correctly, it inserts a layer in the target stack. > If so, I suggest to use @emph and/or @strong to > make sure the reader understands you, and maybe rephrase slightly > to make sure the wording is less ambiguous. > > . Since in this context "run" is something the user types, it > should be @kbd{run}, not @code{run}. > > Otherwise, it is okay to go in. >