From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32193 invoked by alias); 29 Feb 2004 17:42:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32186 invoked from network); 29 Feb 2004 17:42:42 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 29 Feb 2004 17:42:42 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AxUxd-0004iy-2f; Sun, 29 Feb 2004 12:42:41 -0500 Date: Sun, 29 Feb 2004 17:42:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/testsuite] gdb1250.exp: make 'break abort' work with new pending breakpoints Message-ID: <20040229174241.GM15749@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <20040209225601.CFC1F4B363@berman.michael-chastain.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040209225601.CFC1F4B363@berman.michael-chastain.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00900.txt.bz2 On Mon, Feb 09, 2004 at 05:56:01PM -0500, Michael Chastain wrote: > > gdb_breakpoint "main" {allow-pending} > > runto "main" {allow-pending} > > Something like that is okay with me -- exploiting the varargs features > of TCL rather than adding another proc. I'm not fluent in TCL so > I definitely have no sense of style in that area. > > I should just curl up with the TCL book already. Something like this is what I had in mind. Does it work for you? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2004-02-29 Daniel Jacobowitz * gdb.base/gdb1250.exp: Use runto {allow-pending}. * lib/gdb.exp (runto, gdb_breakpoint): Support {allow-pending}. Index: testsuite/gdb.base/gdb1250.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1250.exp,v retrieving revision 1.1 diff -u -p -r1.1 gdb1250.exp --- testsuite/gdb.base/gdb1250.exp 15 Jul 2003 16:28:21 -0000 1.1 +++ testsuite/gdb.base/gdb1250.exp 29 Feb 2004 17:41:14 -0000 @@ -42,7 +42,7 @@ gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_load ${binfile} -if ![runto abort] then { +if ![runto abort {allow-pending}] then { perror "couldn't run to breakpoint" continue } Index: testsuite/lib/gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.49 diff -u -p -r1.49 gdb.exp --- testsuite/lib/gdb.exp 23 Feb 2004 19:27:46 -0000 1.49 +++ testsuite/lib/gdb.exp 29 Feb 2004 17:41:14 -0000 @@ -265,18 +265,32 @@ proc gdb_run_cmd {args} { } } -proc gdb_breakpoint { function } { +# Set a breakpoint at FUNCTION. If there is an additional argument it is +# a list of options; the only currently supported option is allow-pending. + +proc gdb_breakpoint { function args } { global gdb_prompt global decimal + set pending_response n + if {[lsearch -exact [lindex $args 0] allow-pending] != -1} { + set pending_response y + } + send_gdb "break $function\n" # The first two regexps are what we get with -g, the third is without -g. gdb_expect 30 { -re "Breakpoint \[0-9\]* at .*: file .*, line $decimal.\r\n$gdb_prompt $" {} -re "Breakpoint \[0-9\]*: file .*, line $decimal.\r\n$gdb_prompt $" {} -re "Breakpoint \[0-9\]* at .*$gdb_prompt $" {} + -re "Breakpoint \[0-9\]* \\(.*\\) pending.*$gdb_prompt $" { + if {$pending_response == "n"} { + fail "setting breakpoint at $function" + return 0 + } + } -re "Make breakpoint pending.*y or \\\[n\\\]. $" { - send_gdb "n\n" + send_gdb "$pending_response\n" exp_continue } -re "$gdb_prompt $" { fail "setting breakpoint at $function" ; return 0 } @@ -289,15 +303,16 @@ proc gdb_breakpoint { function } { # Since this is the only breakpoint that will be set, if it stops # at a breakpoint, we will assume it is the one we want. We can't # just compare to "function" because it might be a fully qualified, -# single quoted C++ function specifier. +# single quoted C++ function specifier. If there's an additional argument, +# pass it to gdb_breakpoint. -proc runto { function } { +proc runto { function args } { global gdb_prompt global decimal delete_breakpoints - if ![gdb_breakpoint $function] { + if ![gdb_breakpoint $function [lindex $args 0]] { return 0; }