From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16646 invoked by alias); 29 Feb 2004 17:02:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16639 invoked from network); 29 Feb 2004 17:01:59 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 29 Feb 2004 17:01:59 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AxUKF-0004FU-Ew for ; Sun, 29 Feb 2004 12:01:59 -0500 Date: Sun, 29 Feb 2004 17:02:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [ob] Don't clobber inferior_ptid in read_pc_pid Message-ID: <20040229170159.GH15749@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040228173541.GA15776@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040228173541.GA15776@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00895.txt.bz2 On Sat, Feb 28, 2004 at 12:35:41PM -0500, Daniel Jacobowitz wrote: > Another issue found in testing on arm-linux. A return was added to this > function back in June; if we return from the middle of it, we leave > inferior_ptid set to the wrong thread. This causes a "!ptid_equal > (ecs->ptid, inferior_ptid)" test to fail, since we called read_pc_pid > with ecs->ptid. That leads to not calling context_switch; which clobbers > the stepping range for the previous thread; which causes stepping to stop > unexpectedly. > 2004-02-28 Daniel Jacobowitz > > * regcache.c (read_pc_pid): Restore inferior_ptid after reading > PC_REGNUM. I have committed this to HEAD. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer