From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-31133-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1022 invoked by alias); 28 Feb 2004 17:37:44 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1002 invoked from network); 28 Feb 2004 17:37:42 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144)
  by sources.redhat.com with SMTP; 28 Feb 2004 17:37:42 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1SHbNoq000920;
	Sat, 28 Feb 2004 18:37:23 +0100 (CET)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1SHbMbh017935;
	Sat, 28 Feb 2004 18:37:22 +0100 (CET)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i1SHbMx4017932;
	Sat, 28 Feb 2004 18:37:22 +0100 (CET)
Date: Sat, 28 Feb 2004 17:37:00 -0000
Message-Id: <200402281737.i1SHbMx4017932@elgar.kettenis.dyndns.org>
From: Mark Kettenis <kettenis@chello.nl>
To: cagney@gnu.org
CC: ac131313@redhat.com, gdb-patches@sources.redhat.com
In-reply-to: <4040B235.2090405@gnu.org> (message from Andrew Cagney on Sat, 28
	Feb 2004 10:22:29 -0500)
Subject: Re: [rfa:amd64] Fetch 32-bit thread area
References: <403E9C5F.2050803@redhat.com> <200402281151.i1SBpN4u000732@elgar.kettenis.dyndns.org> <4040B235.2090405@gnu.org>
X-SW-Source: 2004-02/txt/msg00833.txt.bz2

   Date: Sat, 28 Feb 2004 10:22:29 -0500
   From: Andrew Cagney <cagney@gnu.org>

   >    Date: Thu, 26 Feb 2004 20:24:47 -0500
   >    From: Andrew Cagney <ac131313@redhat.com>
   > 
   >    Hello,
   > 
   >    This modifies the amd64 code so that, when 32-bit, it fetches the 32-bit 
   >    thread area register (I think this has been posted before?).
   > 
   > Why #if 0 ... #else ... #endif?

   Tipo from testing.

Typo?  You mean that you intended to remove the #if 0 block before
submitting the patch?  Or what?

   > Anyway, I'm not really happy with the 
   > 
   >    switch (TARGET_ARCHITECTURE->mach)
   > 
   > construction.  The other AMD64 native code uses an
   > 
   >    if (gdbarch_ptr_bit (current_gdbarch) == 32)
   > 
   > to distinguish between 32-bit and 64-bit code.  While this may not be
   > completely correct (someone might come up with a native AMD64 ABI with
   > 32-bit pointers), I'd rather not use multiple variations of the
   > 32-bit/64-bit check in the code.

   Is it ok with that change?

If you remove the #if 0 block and re-indent the #else block.  Yes.

Mark