From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17736 invoked by alias); 28 Feb 2004 15:48:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17728 invoked from network); 28 Feb 2004 15:48:07 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 28 Feb 2004 15:48:07 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1SFlvoq000737; Sat, 28 Feb 2004 16:47:57 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1SFlvbh012452; Sat, 28 Feb 2004 16:47:57 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i1SFlv87012449; Sat, 28 Feb 2004 16:47:57 +0100 (CET) Date: Sat, 28 Feb 2004 15:48:00 -0000 Message-Id: <200402281547.i1SFlv87012449@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <4040B1D7.4090805@gnu.org> (message from Andrew Cagney on Sat, 28 Feb 2004 10:20:55 -0500) Subject: Re: [PATCH] Fix compilation of tui/tui.c References: <200402281503.i1SF3p8g011820@elgar.kettenis.dyndns.org> <4040B1D7.4090805@gnu.org> X-SW-Source: 2004-02/txt/msg00824.txt.bz2 Date: Sat, 28 Feb 2004 10:20:55 -0500 From: Andrew Cagney > Ouch. We have serious portability problems with the TUI. We should > either disable it again before the 6.1 release, or be prepared to > release 6.1.1 if any build problems come up. I'm sure we'll see build > problems on many systems that we don't regularly test. > > Anyway, I committed the attached such that FreeBSD (and probably the > other BSD's work again/. It works on my bsd system (how do you think I was testing it)? I didn't check on OpenBSD or NetBSD, but I supposed they would suffer from the same problems as my FreeBSD-system. What portability problem. The TUI code is including header files and using library functions that we've never used before in GDB. We've already seen the fall-out from this on HP-UX and Solaris, and now on FreeBSD. I'm just afraid that more of these problems will surface when somebody tries to build GDB other platforms. Is there a reason for changing "" to <>, it breaks some of GDB's scripts. I changed because we seem to use <> everywhere else in GDB for the readline includes, e.g. event-top.c, completer.c. I think it's good to be consistent; you get less surprises that way. Mark