Re: [RFA/dwarf] Optimize partial DIE reading for uninteresting DIEs

Jim Blandy
2004-03-10T14:56:03Z

Daniel Jacobowitz <drow@false.org> writes:
> On Thu, Feb 26, 2004 at 10:03:10PM -0500, Daniel Jacobowitz wrote:
> > On Thu, Feb 26, 2004 at 09:58:32PM -0500, Jim Blandy wrote:
> > > It would be interesting to compare profiling results between two GDB's
> > > that differ only in whether they use your attribute skipper or the
> > > attribute value reader.
> >
> > For this patch, the changes were pretty small. For the larger change,
> > with just partial symbol table reading, read_unsigned_leb128 dropped
> > way down and skip_leb128 didn't climb equally far up.
> >
> > Let me reproduce those results, though. Something seems suspicious.
>
> Nah, seems good, although the difference is just a few percent at most;
> I trust from my earlier measurements that it will make more of a
> difference down the road. I've checked this in to HEAD.

Okay, sounds good.