From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20769 invoked by alias); 26 Feb 2004 23:03:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20761 invoked from network); 26 Feb 2004 23:03:01 -0000 Received: from unknown (HELO faui10.informatik.uni-erlangen.de) (131.188.31.10) by sources.redhat.com with SMTP; 26 Feb 2004 23:03:01 -0000 Received: from faui1d.informatik.uni-erlangen.de (faui1d [131.188.31.34]) by faui10.informatik.uni-erlangen.de (8.9.3p3/8.1.9-FAU) with ESMTP id AAA02930; Fri, 27 Feb 2004 00:03:00 +0100 (CET) From: Ulrich Weigand Received: (from weigand@localhost) by faui1d.informatik.uni-erlangen.de (8.9.3p3/8.1.6-FAU) id AAA00593; Fri, 27 Feb 2004 00:03:00 +0100 (CET) Message-Id: <200402262303.AAA00593@faui1d.informatik.uni-erlangen.de> Subject: Re: [PATCH] Enable DWARF-2 frames on S/390 To: cagney@gnu.org (Andrew Cagney) Date: Thu, 26 Feb 2004 23:03:00 -0000 Cc: weigand@i1.informatik.uni-erlangen.de (Ulrich Weigand), gdb-patches@sources.redhat.com In-Reply-To: <403E5DE5.4030409@gnu.org> from "Andrew Cagney" at Feb 26, 2004 03:58:13 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00786.txt.bz2 Hello Andrew, > > now that all pieces of the DWARF-2 CFI rework have gone in, and > > the big s390 backend reorganization was also committed, this patch > > is the only thing that's missing to enable DWARF-2 frame support > > on s390. > > > > Do you think a copyright assignment is required for this? While > > it's longer than 10 lines, it doesn't really contain anything > > that should be significant w.r.t. intellectual property -- the > > s390_dwarf2_frame_init_reg routine only implements the publicly > > documented s390 ABI calling convention ... > > Can you describe the change with one paragraph of english? The change consists of installing a dwarf2_frame_set_init_reg callback that overrides the default register state initializtion to instead perform the following: set all call-saved registers to DWARF2_FRAME_REG_SAME_VALUE, all call-clobbered registers to DWARF2_FRAME_REG_UNDEFINED, and the virtual PC register to DWARF2_FRAME_REG_RA. Which registers count as call-saved vs. call-clobbered is defined by the Linux for S/390 and Linux for zSeries ABI documents. Bye, Ulrich -- Dr. Ulrich Weigand weigand@informatik.uni-erlangen.de