From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20561 invoked by alias); 26 Feb 2004 23:02:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20550 invoked from network); 26 Feb 2004 23:02:43 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 26 Feb 2004 23:02:43 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AwUWe-0002TM-Hu; Thu, 26 Feb 2004 18:02:40 -0500 Date: Thu, 26 Feb 2004 23:02:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] (testsuite/Ada) Add gdb_compile_ada Message-ID: <20040226230239.GA8487@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20040224195615.GC542@gnat.com> <20040224230812.GE542@gnat.com> <20040225183211.GH1105@gnat.com> <20040225201749.GA21911@nevyn.them.org> <20040226223742.GH1154@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040226223742.GH1154@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00785.txt.bz2 On Thu, Feb 26, 2004 at 02:37:42PM -0800, Joel Brobecker wrote: > And then building a typical Ada program will be done using the > following command: > > % gnatmake -P$objdir/gdb.ada/gnat_ada -g -o > > where is the name of the Ada file (*basename* only) > and is the name of the executable (can be basename or fullname, > it doesn't matter) Great. > > Also, gdb_compile_ada may want to remove the incremental files in this > > case, since the testsuite will not use them. > > gnatmake will. For instance gnatmake won't recompile the test programs > on subsequent runs, unless the sources have changes. Or if we have two > test programs depending on the same unit, this unit will only be compiled > once. I think we should keep them, they are useful. Well, I'm not so sure that qualifies as useful for the testsuite, but if they go into gdb.ada I don't care :) > > > + lappend options "compiler=gnatmake" > > > > See find_gcc in dejagnu's libgloss.exp. > > Could you explain a bit more what you mean (sorry, dejagnu is still > new to me, and I have allergic reactions to tcl and expect :-/)? > Do you means that I should create a new find_gnatmake function and > then do > > lappend options "compiler=[find_gnatmake]" > > instead? I think this is the last sticky point to look at before being > able to properly submit these changes for inclusion. Aye. You can put find_gnatmake in gdb.exp for now and submit it to dejagnu later. The basic goals of the function are: - Find an in-tree gnatmake and pass it appropriate options to run from in-tree, for testing a combined tree. - Use [transform], which will supply the appropriate cross prefixes. > load_lib libgloss.exp > > proc gdb_begin {args expected_output} { > gdb_test "begin $args" "$expected_output" "begin command" > } What's begin do again in your sources? Also, I'm not sure about the need for an ada.exp; what else do you expet to go here? Otherwise it looks reasonable. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer