Re: [patch] Gdbserver error codes

Andrew Cagney
2004-02-26T17:41:38Z

> On Thu, Feb 26, 2004 at 12:08:08PM -0500, Nathan J. Williams wrote:
>
>>> Daniel Jacobowitz <drow@false.org> writes:
>>>
>>
>>>> > Thanks to Eli for making me look closer at this. Parts of remote.c
>>>> > will reject ENN; in particular, ENN will cause remote_write_bytes to return
>>>> > an error but remote_read_bytes not to. Thus the 0xffffffff gdbserver has
>>>> > been printing instead of an error message for inaccessible memory regions.
>>
>>>
>>> I still don't see that gdbserver will actually return an error if the
>>> memory read fails; the target_ops read routine doesn't return an error
>>> to the upper level, and the low transfer routines don't check the
>>> ptrace return value and errno. I can put together my patches to
>>> address this if there's interest.
>
>
> Oops, you're right.
>
> Of course there is interest - I'm always interested in fixes to
> gdbserver. Do you have or can you get a copyright assignment?

Wasabi have a blanket assignment.

>>> (while I'm at it, is there anything specifying that the hex format for
>>> returned data is lowercase hex, or is the capital-E error return the only
>>> implicit statement of that?)
>
>
> I have no idea.

In general? Assume its lowercase. No, it probably isn't explicit.

Andrew