From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16649 invoked by alias); 26 Feb 2004 15:10:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16641 invoked from network); 26 Feb 2004 15:10:35 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 26 Feb 2004 15:10:35 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AwN9m-0006K1-Jy for ; Thu, 26 Feb 2004 10:10:34 -0500 Date: Thu, 26 Feb 2004 15:10:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: [patch] Gdbserver error codes Message-ID: <20040226151034.GA24170@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00760.txt.bz2 Thanks to Eli for making me look closer at this. Parts of remote.c will reject ENN; in particular, ENN will cause remote_write_bytes to return an error but remote_read_bytes not to. Thus the 0xffffffff gdbserver has been printing instead of an error message for inaccessible memory regions. Also updated some copyright dates. Checked in. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2004-02-26 Daniel Jacobowitz * remote-utils.c (write_enn): Use "E01" instead of "ENN" for the error packet. * server.c, target.h: Update copyright years. Index: gdbserver/remote-utils.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v retrieving revision 1.17 diff -u -p -r1.17 remote-utils.c --- gdbserver/remote-utils.c 5 Jun 2003 14:26:58 -0000 1.17 +++ gdbserver/remote-utils.c 26 Feb 2004 15:08:02 -0000 @@ -1,6 +1,6 @@ /* Remote utility routines for the remote server for GDB. Copyright 1986, 1989, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, - 2002 + 2002, 2003, 2004 Free Software Foundation, Inc. This file is part of GDB. @@ -487,9 +487,10 @@ write_ok (char *buf) void write_enn (char *buf) { + /* Some day, we should define the meanings of the error codes... */ buf[0] = 'E'; - buf[1] = 'N'; - buf[2] = 'N'; + buf[1] = '0'; + buf[2] = '1'; buf[3] = '\0'; } Index: gdbserver/server.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.c,v retrieving revision 1.17 diff -u -p -r1.17 server.c --- gdbserver/server.c 25 Feb 2004 20:41:29 -0000 1.17 +++ gdbserver/server.c 26 Feb 2004 15:08:02 -0000 @@ -1,5 +1,5 @@ /* Main code for remote server for GDB. - Copyright 1989, 1993, 1994, 1995, 1997, 1998, 1999, 2000, 2002 + Copyright 1989, 1993, 1994, 1995, 1997, 1998, 1999, 2000, 2002, 2003, 2004 Free Software Foundation, Inc. This file is part of GDB. Index: gdbserver/target.h =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/target.h,v retrieving revision 1.9 diff -u -p -r1.9 target.h --- gdbserver/target.h 25 Feb 2004 20:41:29 -0000 1.9 +++ gdbserver/target.h 26 Feb 2004 15:08:02 -0000 @@ -1,5 +1,5 @@ /* Target operations for the remote server for GDB. - Copyright 2002 + Copyright 2002, 2003, 2004 Free Software Foundation, Inc. Contributed by MontaVista Software.