Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] (testsuite/Ada) Add gdb_compile_ada
Date: Tue, 24 Feb 2004 22:40:00 -0000	[thread overview]
Message-ID: <20040224224031.GD542@gnat.com> (raw)
In-Reply-To: <20040224195615.GC542@gnat.com>

Hello,

> 2004-02-24  J. Brobecker  <brobecker@gnat.com>
> 
>         * lib/gdb.exp (gdb_compile_ada): New function.

Please ignore this patch. It has a few problems:

  - Object files are placed in the testsuite directory. I'd rather
    see them being placed in gdb.ada.

  - There is a problem with gdb_compile_ada. In Ada target_compile
    always returns some output, so the current implementation thinks
    the compilation fails, while it is not necessarily the case.
    I changed the test to check for the dest file, rather than
    analyzing the output.

Will send an updated patch when I have a complete ada testcase working.


> Index: lib/gdb.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
> retrieving revision 1.49
> diff -u -p -r1.49 gdb.exp
> --- lib/gdb.exp	23 Feb 2004 19:27:46 -0000	1.49
> +++ lib/gdb.exp	24 Feb 2004 19:50:10 -0000
> @@ -1361,6 +1361,17 @@ proc gdb_compile_objc {source dest type 
>      }
>  }
>  
> +proc gdb_compile_ada {source dest type options} {
> +    
> +    lappend options "compiler=gnatmake"
> +
> +    set result [target_compile $source $dest $type $options]
> +    if { $result != "" } {
> +        verbose "target_compile failed: $result" 2
> +        return "gdb_compile_ada failed: $result"
> +    }
> +}
> +
>  proc send_gdb { string } {
>      global suppress_flag;
>      if { $suppress_flag } {


-- 
Joel


  reply	other threads:[~2004-02-24 22:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-24 19:56 Joel Brobecker
2004-02-24 22:40 ` Joel Brobecker [this message]
2004-02-24 23:08 ` Joel Brobecker
2004-02-25 18:32   ` Joel Brobecker
2004-02-25 20:17     ` Daniel Jacobowitz
2004-02-26 22:37       ` Joel Brobecker
2004-02-26 23:02         ` Daniel Jacobowitz
2004-03-19  0:09           ` Joel Brobecker
2004-03-03  4:21             ` Joel Brobecker
2004-03-05  4:18             ` Daniel Jacobowitz
2004-03-05  6:03               ` Joel Brobecker
2004-03-05 16:48                 ` Daniel Jacobowitz
2004-03-19  0:09                   ` Daniel Jacobowitz
2004-03-26 23:42                   ` Joel Brobecker
2004-03-26 23:46                     ` Daniel Jacobowitz
2004-03-27  0:07                       ` Joel Brobecker
2004-03-19  0:09                 ` Joel Brobecker
2004-03-19  0:09               ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040224224031.GD542@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox