From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26758 invoked by alias); 20 Feb 2004 00:17:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26634 invoked from network); 20 Feb 2004 00:17:23 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 20 Feb 2004 00:17:23 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1K0HNb11822 for ; Thu, 19 Feb 2004 19:17:23 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1K0HMM28418; Thu, 19 Feb 2004 19:17:22 -0500 Received: from 192.168.1.129 (vpn50-71.rdu.redhat.com [172.16.50.71]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1K0HKX09620; Thu, 19 Feb 2004 16:17:20 -0800 From: Fred Fish Reply-To: fnf@ninemoons.com To: Elena Zannoni , fnf@redhat.com Subject: Re: [RFA] Eliminate useless test of variable before overwriting it in sh-tdep.c Date: Fri, 20 Feb 2004 00:17:00 -0000 User-Agent: KMail/1.5.4 Cc: gdb-patches@sources.redhat.com References: <200402121512.40574.fnf@ninemoons.com> <16432.58684.128094.521393@localhost.redhat.com> In-Reply-To: <16432.58684.128094.521393@localhost.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402191717.18292.fnf@ninemoons.com> X-SW-Source: 2004-02/txt/msg00549.txt.bz2 On Monday 16 February 2004 08:43, Elena Zannoni wrote: > > ok. Committed. -Fred 2004-02-19 Fred Fish * sh-tdep.c (sh_analyze_prologue): Eliminate useless test of cache->uses_fp prior to setting it. Index: sh-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sh-tdep.c,v retrieving revision 1.164 diff -c -p -r1.164 sh-tdep.c *** sh-tdep.c 19 Feb 2004 23:05:07 -0000 1.164 --- sh-tdep.c 20 Feb 2004 00:14:57 -0000 *************** sh_analyze_prologue (CORE_ADDR pc, CORE_ *** 482,489 **** } else if (IS_MOV_SP_FP (inst)) { ! if (!cache->uses_fp) ! cache->uses_fp = 1; /* At this point, only allow argument register moves to other registers or argument register moves to @(X,fp) which are moving the register arguments onto the stack area allocated --- 482,488 ---- } else if (IS_MOV_SP_FP (inst)) { ! cache->uses_fp = 1; /* At this point, only allow argument register moves to other registers or argument register moves to @(X,fp) which are moving the register arguments onto the stack area allocated