From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31689 invoked by alias); 17 Feb 2004 16:04:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31681 invoked from network); 17 Feb 2004 16:04:43 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 17 Feb 2004 16:04:43 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1HG4gb04012 for ; Tue, 17 Feb 2004 11:04:42 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1HG4fM01384 for ; Tue, 17 Feb 2004 11:04:41 -0500 Received: from cygbert.vinschen.de (vpn50-15.rdu.redhat.com [172.16.50.15]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1HG4dX27534 for ; Tue, 17 Feb 2004 08:04:39 -0800 Received: by cygbert.vinschen.de (Postfix, from userid 500) id A7121580E9; Tue, 17 Feb 2004 17:04:32 +0100 (CET) Date: Tue, 17 Feb 2004 16:04:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.*: Rename DSP bank registers Message-ID: <20040217160432.GA30632@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040216154127.GH18953@cygbert.vinschen.de> <16434.10422.944771.777608@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16434.10422.944771.777608@localhost.redhat.com> User-Agent: Mutt/1.4.2i X-SW-Source: 2004-02/txt/msg00471.txt.bz2 On Feb 17 09:44, Elena Zannoni wrote: > Corinna Vinschen writes: > > I'd like to propose the below patch, which renames the used enum > > values from R0_BANK_REGNUM and R7_BANK_REGNUM to DSP_R0_BANK_REGNUM > > and DSP_R7_BANK_REGNUM respectively. IMHO, that's less confusing > > and allows to use the register bank numbering scheme of non-dsp > > CPUs at a later point. > > Interesting, this is what it was originally before your change: > - if (nr >= DSP_R0_BANK_REGNUM && nr <= DSP_R7_BANK_REGNUM) > - return nr - DSP_R0_BANK_REGNUM + SIM_SH_R0_BANK_REGNUM; > + if (nr >= R0_BANK_REGNUM && nr <= R7_BANK_REGNUM) > + return nr - R0_BANK_REGNUM + SIM_SH_R0_BANK_REGNUM; Half a year ago it seemed to be right. Well... the world keeps turning. Thanks, applied, Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.