From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26171 invoked by alias); 12 Feb 2004 17:29:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26111 invoked from network); 12 Feb 2004 17:29:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 12 Feb 2004 17:29:18 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1CHTFb21759 for ; Thu, 12 Feb 2004 12:29:15 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1CHTEM01693 for ; Thu, 12 Feb 2004 12:29:14 -0500 Received: from cygbert.vinschen.de (vpn50-22.rdu.redhat.com [172.16.50.22]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1CHTCX21113 for ; Thu, 12 Feb 2004 09:29:13 -0800 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 141E25808E; Thu, 12 Feb 2004 18:29:06 +0100 (CET) Date: Thu, 12 Feb 2004 17:29:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: [RFA] sh-tdep.c: Define only the minimal register set in sh_generic_register_name Message-ID: <20040212172905.GF3854@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2i X-SW-Source: 2004-02/txt/msg00319.txt.bz2 Hi, while looking into the sh_generic_register_name function, I began to wonder why that function defines a register set, which is not exactly generic, but instead gives a name to all 59 register entries. Many of them are only correct on CPUs with FPU and/or register banks. IMHO, the generic_name function should only define the maximum common register set, which is the same as the one for the basic sh CPU variant. Therefore I'd like to propose the following patch, which does exactly that. An alternative approach would be, to remove the sh_generic_register_name entirely and use sh_sh_register_name instead. Thanks for considering, Corinna ChangeLog: * sh-tdep.c (sh_generic_register_name): Only define the maximum common register set. Index: sh-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sh-tdep.c,v retrieving revision 1.158 diff -u -p -r1.158 sh-tdep.c --- sh-tdep.c 11 Feb 2004 15:40:28 -0000 1.158 +++ sh-tdep.c 12 Feb 2004 17:28:22 -0000 @@ -81,12 +81,12 @@ sh_generic_register_name (int reg_nr) "r0", "r1", "r2", "r3", "r4", "r5", "r6", "r7", "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15", "pc", "pr", "gbr", "vbr", "mach", "macl", "sr", - "fpul", "fpscr", - "fr0", "fr1", "fr2", "fr3", "fr4", "fr5", "fr6", "fr7", - "fr8", "fr9", "fr10", "fr11", "fr12", "fr13", "fr14", "fr15", - "ssr", "spc", - "r0b0", "r1b0", "r2b0", "r3b0", "r4b0", "r5b0", "r6b0", "r7b0", - "r0b1", "r1b1", "r2b1", "r3b1", "r4b1", "r5b1", "r6b1", "r7b1", + "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", + "", "", + "", "", "", "", "", "", "", "", + "", "", "", "", "", "", "", "", }; if (reg_nr < 0) return NULL; -- Corinna Vinschen Cygwin Developer Red Hat, Inc.