From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22558 invoked by alias); 12 Feb 2004 01:11:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22453 invoked from network); 12 Feb 2004 01:11:03 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 12 Feb 2004 01:11:03 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1C1B2b13755 for ; Wed, 11 Feb 2004 20:11:02 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1C1B1M02546; Wed, 11 Feb 2004 20:11:01 -0500 Received: from 192.168.1.129 (vpn50-32.rdu.redhat.com [172.16.50.32]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1C1AxX27060; Wed, 11 Feb 2004 17:10:59 -0800 From: Fred Fish Reply-To: fnf@redhat.com To: fnf@redhat.com, Daniel Jacobowitz Subject: Re: [RFA] Fix several problems with the gdb.arch/gdb1291.exp test Date: Thu, 12 Feb 2004 01:11:00 -0000 User-Agent: KMail/1.5.4 Cc: gdb-patches@sources.redhat.com References: <200402101807.37718.fnf@ninemoons.com> <20040211011715.GA11122@nevyn.them.org> <200402101828.30369.fnf@ninemoons.com> In-Reply-To: <200402101828.30369.fnf@ninemoons.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402111810.56493.fnf@ninemoons.com> X-SW-Source: 2004-02/txt/msg00313.txt.bz2 On Tuesday 10 February 2004 18:28, Fred Fish wrote: > > I recommend writing the whole test in assembly instead; this is > > gdb.arch, after all. We don't want to be sensitive to GCC bugs. > > That sounds like the best solution. > > Back to the drawing board... OK, here is an updated patch. With the current gdb sources this produces the log message: KFAIL: gdb.arch/gdb1291.exp: backtrace with local variable larger than 256 bytes (PRMS: gdb/1291) -Fred 2004-02-11 Fred Fish * gdb.arch/gdb1291.c: Remove * gdb.arch/gdb1291.s: New test input file. * gdb.arch/gdb1291.exp: Expand test to check case that should not fail. Test for correct result, known incorrect result, other failures and timeouts. Index: gdb/testsuite/gdb.arch/gdb1291.c =================================================================== RCS file: gdb/testsuite/gdb.arch/gdb1291.c diff -N gdb/testsuite/gdb.arch/gdb1291.c *** gdb/testsuite/gdb.arch/gdb1291.c 4 Feb 2004 14:41:20 -0000 1.2 --- /dev/null 1 Jan 1970 00:00:00 -0000 *************** *** 1,45 **** - /* Copyright 2003, 2004 Free Software Foundation, Inc. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. - - Please email any bugs, comments, and/or additions to this file to: - bug-gdb@gnu.org - - This file is part of the gdb testsuite. */ - - void sub (void); - - main() - { - sub(); - } - - asm(".text\n" - " .align 5\n" - "sub:\n" - "_sub:\n" - " mov.l r14,@-r15\n" - " mov.w .STACK2,r3\n" - " sub r3,r15\n" - " mov r15,r14\n" - " mov.w .STACK2,r7\n" - " add r7,r14\n" - " mov r14,r15\n" - " mov.l @r15+,r14\n" - " rts\n" - " nop\n" - " .align 1\n" - ".STACK2:\n" - " .short 260\n"); --- 0 ---- Index: gdb/testsuite/gdb.arch/gdb1291.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/gdb1291.exp,v retrieving revision 1.1 diff -c -p -r1.1 gdb1291.exp *** gdb/testsuite/gdb.arch/gdb1291.exp 3 Nov 2003 17:42:52 -0000 1.1 --- gdb/testsuite/gdb.arch/gdb1291.exp 12 Feb 2004 00:21:11 -0000 *************** if ![istarget "sh-*-*"] then { *** 37,45 **** } set testfile "gdb1291" ! set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} ! if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } --- 37,45 ---- } set testfile "gdb1291" ! set srcfile ${testfile}.s set binfile ${objdir}/${subdir}/${testfile} ! if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ""] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } *************** if ![runto_main] then { *** 56,62 **** gdb_suppress_tests } ! gdb_test "b sub" "Breakpoint 2*" "set breakpoint" ! gdb_test "c" "Breakpoint 2*" "get to sub" ! gdb_test "bt" "#0\[ \t\]*$hex \\(\\) at sh-bt.*\r\n#1\[ \t\]*$hex in main.*" \ ! "backtrace in gdb1291" --- 56,92 ---- gdb_suppress_tests } ! gdb_test "b sub1" "Breakpoint 2.*" "set breakpoint" ! gdb_test "c" "Breakpoint 2.* sub1 .*" "get to sub1" ! ! send_gdb "bt\n" ! gdb_expect { ! -re "#0.* sub1 .*\r\n#1\[ \t\]*$hex in main \\(\\).*\r\n$gdb_prompt $" { ! pass "backtrace with local variable less than or equal to 256 bytes" ! } ! -re ".*$gdb_prompt $" { ! fail "backtrace with local variable less than or equal to 256 bytes" ! } ! timeout { ! fail "backtrace with local variable less than or equal to 256 bytes (timeout)" ! } ! } ! ! gdb_test "b sub2" "Breakpoint 3.*" "set breakpoint" ! gdb_test "c" "Breakpoint 3.* sub2 .*" "get to sub2" ! ! send_gdb "bt\n" ! gdb_expect { ! -re "#0.* sub2 .*\r\n#1\[ \t\]*$hex in main \\(\\).*\r\n$gdb_prompt $" { ! pass "backtrace with local variable larger than 256 bytes" ! } ! -re "#0.* sub2 .*\r\n#1 0x00000000 in \\?\\? \\(\\).*\r\n$gdb_prompt $" { ! kfail "gdb/1291" "backtrace with local variable larger than 256 bytes" ! } ! -re ".*$gdb_prompt $" { ! fail "backtrace with local variable larger than 256 bytes" ! } ! timeout { ! fail "backtrace with local variable larger than 256 bytes (timeout)" ! } ! } Index: gdb/testsuite/gdb.arch/gdb1291.s =================================================================== RCS file: gdb/testsuite/gdb.arch/gdb1291.s diff -N gdb/testsuite/gdb.arch/gdb1291.s *** /dev/null 1 Jan 1970 00:00:00 -0000 --- gdb/testsuite/gdb.arch/gdb1291.s 12 Feb 2004 00:21:11 -0000 *************** *** 0 **** --- 1,129 ---- + ! Copyright 2003 Free Software Foundation, Inc. + ! + ! This program is free software; you can redistribute it and/or modify + ! it under the terms of the GNU General Public License as published by + ! the Free Software Foundation; either version 2 of the License, or + ! (at your option) any later version. + ! + ! This program is distributed in the hope that it will be useful, + ! but WITHOUT ANY WARRANTY; without even the implied warranty of + ! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + ! GNU General Public License for more details. + ! + ! You should have received a copy of the GNU General Public License + ! along with this program; if not, write to the Free Software + ! Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + ! + ! Please email any bugs, comments, and/or additions to this file to: + ! bug-gdb@gnu.org + ! + ! This file is part of the gdb testsuite. + ! + ! It was generated using "sh-elf-gcc -S gdb1291.c", using the following + ! source file: + ! + ! #include + ! + ! main() + ! { + ! printf("hello world\n"); + ! sub1(); + ! sub2(); + ! } + ! sub1() + ! { + ! int buf[64]; + ! + ! } + ! + ! sub2() + ! { + ! int buf[65]; + ! + ! } + ! + ! We use a pregenerated assembly file as the test input to avoid possible + ! problems with future versions of gcc generating different code. + + .file "gdb1291.c" + .text + .section .rodata + .align 2 + .LC0: + .string "hello world\n" + .text + .align 1 + .global _main + .type _main, @function + _main: + mov.l r14,@-r15 + sts.l pr,@-r15 + mov r15,r14 + mov.l .L2,r1 + mov r1,r4 + mov.l .L3,r1 + jsr @r1 + nop + mov.l .L4,r1 + jsr @r1 + nop + mov.l .L5,r1 + jsr @r1 + nop + mov r14,r15 + lds.l @r15+,pr + mov.l @r15+,r14 + rts + nop + .L6: + .align 2 + .L2: + .long .LC0 + .L3: + .long _printf + .L4: + .long _sub1 + .L5: + .long _sub2 + .size _main, .-_main + .align 1 + .global _sub1 + .type _sub1, @function + _sub1: + mov.l r14,@-r15 + sts.l pr,@-r15 + add #-128,r15 + add #-128,r15 + mov r15,r14 + mov.w .L8,r7 + add r7,r14 + mov r14,r15 + lds.l @r15+,pr + mov.l @r15+,r14 + rts + nop + .align 1 + .L8: + .short 256 + .size _sub1, .-_sub1 + .align 1 + .global _sub2 + .type _sub2, @function + _sub2: + mov.l r14,@-r15 + sts.l pr,@-r15 + mov.w .L11,r1 + sub r1,r15 + mov r15,r14 + mov.w .L11,r7 + add r7,r14 + mov r14,r15 + lds.l @r15+,pr + mov.l @r15+,r14 + rts + nop + .align 1 + .L11: + .short 260 + .size _sub2, .-_sub2 + .ident "GCC: (GNU) 3.5.0 20040204 (experimental)"