From: Fred Fish <fnf@ninemoons.com>
To: Daniel Jacobowitz <drow@mvista.com>, fnf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix several problems with the gdb.arch/gdb1291.exp test
Date: Wed, 11 Feb 2004 01:28:00 -0000 [thread overview]
Message-ID: <200402101828.30369.fnf@ninemoons.com> (raw)
In-Reply-To: <20040211011715.GA11122@nevyn.them.org>
On Tuesday 10 February 2004 18:17, Daniel Jacobowitz wrote:
> Sorry, not OK. There are at least three problems:
All excellent points, as usual. Good example of why it's important to
have reviews of all patches. :-)
> - You've added a kfail pattern for PR 1291 that doesn't match the
> description in the PR; the less than 256 bytes case shouldn't
> be a kfail.
Another oops. That piece of the cloned test wasn't meant to be included.
> I recommend writing the whole test in assembly instead; this is
> gdb.arch, after all. We don't want to be sensitive to GCC bugs.
That sounds like the best solution.
Back to the drawing board...
-Fred
next prev parent reply other threads:[~2004-02-11 1:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-11 1:07 Fred Fish
2004-02-11 1:17 ` Daniel Jacobowitz
2004-02-11 1:28 ` Fred Fish [this message]
2004-02-11 2:11 ` Fred Fish
2004-02-12 1:11 ` Fred Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402101828.30369.fnf@ninemoons.com \
--to=fnf@ninemoons.com \
--cc=drow@mvista.com \
--cc=fnf@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox