From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4607 invoked by alias); 9 Feb 2004 15:38:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4581 invoked from network); 9 Feb 2004 15:38:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 9 Feb 2004 15:38:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AqDU5-0007jO-Tz; Mon, 09 Feb 2004 10:38:05 -0500 Date: Mon, 09 Feb 2004 15:38:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/testsuite] gdb1250.exp: make 'break abort' work with new pending breakpoints Message-ID: <20040209153805.GA29343@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <20040209072340.665D84B104@berman.michael-chastain.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040209072340.665D84B104@berman.michael-chastain.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00199.txt.bz2 On Mon, Feb 09, 2004 at 02:23:40AM -0500, Michael Chastain wrote: > This patch enhances gdb.base/gdb1250.exp so that it works with > the new pending-breakpoint interface. This test wants to set a > breakpoint on 'abort', which may be in a shared library. > > Of course it still works with the old 'just quietly set the breakpoint' > interface. > > I tested on native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5-rh. > I tested with gdb 6.0 and gdb HEAD, gcc 3.3.2, binutils 2.14 and > binutils HEAD, dwarf-2 and stabs+. All the tests PASSed in all > configurations. > > This test is sensitive to the version of binutils because binutils HEAD > has a PLT optimization for shared library functions. So it used to fail with binutils HEAD, right? > > Okay to commit? This I'm not so sure about. - Should there be a version of gdb_breakpoint that answers yes to the pending question? - If so, should runto use it? Or should there be a version of runto that does? I think the latter might be best but I don't know what to call them. Maybe: gdb_breakpoint_allow_pending runto_allow_pending > 2004-02-09 Michael Chastain > > * gdb.base/gdb1250.exp: Improve 'break abort' to work with new > pending-breakpoint user interface. Fixing this is great though! -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer