From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30379 invoked by alias); 7 Feb 2004 02:34:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30266 invoked from network); 7 Feb 2004 02:34:29 -0000 Received: from unknown (HELO granger.mail.mindspring.net) (207.69.200.148) by sources.redhat.com with SMTP; 7 Feb 2004 02:34:29 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by granger.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1ApIIe-0005JE-00; Fri, 06 Feb 2004 21:34:28 -0500 Received: by berman.michael-chastain.com (Postfix, from userid 502) id 40A0D4B364; Fri, 6 Feb 2004 21:34:25 -0500 (EST) To: ezannoni@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH/ob] unify objfile obstacks(2/4) Message-Id: <20040207023425.40A0D4B364@berman.michael-chastain.com> Date: Sat, 07 Feb 2004 02:34:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-02/txt/msg00140.txt.bz2 This comment in dbxread.c seems a bit wack now: - /* Read the string table and stash it away in the psymbol_obstack. It is + /* Read the string table and stash it away in the objfile_obstack. It is only needed as long as we need to expand psymbols into full symbols, so when we blow away the psymbol the string table goes away as well. The psymbols are going to have the same lifetime as the symbols, so talking about blowing away the psymbols seems weird. Other than that, looks okay to me. And I applied the patch and didn't see any more psymbol_obstack afterwards. Michael C === 2004-02-06 Elena Zannoni * dbxread.c (dbx_symfile_init, start_psymtab, end_psymtab, coffstab_build_psymtabs, elfstab_build_psymtabs) (stabsect_build_psymtabs): Replace psymbol_obstack with objfile_obstack. * dwarf2-frame.c (decode_frame_entry_1): Ditto. * dwarf2read.c (dwarf2_build_psymtabs_hard, dwarf2_read_section): Ditto. * dwarfread.c (scan_compilation_units): Ditto. * elfread.c (elfstab_offset_sections): Ditto. * hppa-tdep.c (read_unwind_info): Ditto. * hpread.c (hpread_build_psymtabs, hpread_start_psymtab) (hpread_end_psymtab): Ditto. * mdebugread.c (mdebug_build_psymtabs, add_pending) (parse_partial_symbols, new_psymtab, elfmdebug_build_psymtabs): Ditto. * mips-tdep.c (non_heuristic_proc_desc): Ditto. * objfiles.c (add_to_objfile_sections) (build_objfile_section_table): Ditto. (allocate_objfile): Remove init of psymbol_obstack. (free_objfile): Remove freeing of psymbol_obstack. * objfiles.h (struct objfile): Remove field psymbol_obstack. Update comments. * pa64solib.c (pa64_solib_add_solib_objfile): Replace psymbol_obstack with objfile_obstack. * solib-sunos.c (allocate_rt_common_objfile): Remove init of psymbol_obstack. * somread.c (som_symfile_offsets, init_import_symbols) (init_export_symbols): Replace psymbol_obstack with objfile_obstack. * somsolib.c (som_solib_add_solib_objfile): Ditto. * symfile.c (default_symfile_offsets, syms_from_objfile) (reread_symbols): Remove freeing and init of psymbol_obstack. (cashier_psymtab): Update comment. * symmisc.c (print_objfile_statistics): Don't report stats for psymbol obstack. * symtab.h (struct general_symbol_info, struct partial_symtab): Update comments. * xcoffread.c (xcoff_start_psymtab, xcoff_end_psymtab, swap_sym) (xcoff_symfile_offsets): Replace psymbol_obstack with objfile_obstack.