From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-30340-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 5140 invoked by alias); 2 Feb 2004 21:23:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5127 invoked from network); 2 Feb 2004 21:23:03 -0000
Received: from unknown (HELO nevyn.them.org) (66.93.172.17)
  by sources.redhat.com with SMTP; 2 Feb 2004 21:23:03 -0000
Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian))
	id 1AnlX5-0002HA-05; Mon, 02 Feb 2004 16:23:03 -0500
Date: Mon, 02 Feb 2004 21:23:00 -0000
From: Daniel Jacobowitz <drow@mvista.com>
To: Fred Fish <fnf@ninemoons.com>
Cc: gdb-patches@sources.redhat.com, fnf@redhat.com
Subject: Re: [RFA] Fix testsuite gdb.base/bang.exp to work with remote targets
Message-ID: <20040202212302.GB7982@nevyn.them.org>
Mail-Followup-To: Fred Fish <fnf@ninemoons.com>,
	gdb-patches@sources.redhat.com, fnf@redhat.com
References: <200402021326.08063.fnf@ninemoons.com> <200402021356.34295.fnf@ninemoons.com> <20040202210148.GA5510@nevyn.them.org> <200402021416.53341.fnf@ninemoons.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200402021416.53341.fnf@ninemoons.com>
User-Agent: Mutt/1.5.1i
X-SW-Source: 2004-02/txt/msg00040.txt.bz2

On Mon, Feb 02, 2004 at 02:16:53PM -0700, Fred Fish wrote:
> On Monday 02 February 2004 14:01, Daniel Jacobowitz wrote:
> > I would prefer this.  It also handles gdbserver correctly (restart the
> > server, continue).
> 
> OK, here is a revised patch.  Note this also preserves the previous
> behavior, discussed on gdb-patches for other proposed changes to
> bang.exp, where nothing is allowed after the "Program exited
> normally." message.

Thanks - I meant to mention that in my last message but forgot.  Please
check this in.

> 
> -Fred
> 
> 2004-02-02  Fred Fish  <fnf@redhat.com>
> 
> 	* gdb.base/bang.exp: Use gdb_run_cmd so this tests works with
> 	remote targets.  Update copyright years.
> 
> Index: gdb.base/bang.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/bang.exp,v
> retrieving revision 1.1
> diff -c -p -r1.1 bang.exp
> *** gdb.base/bang.exp	24 Jun 2003 22:04:06 -0000	1.1
> --- gdb.base/bang.exp	2 Feb 2004 21:11:55 -0000
> ***************
> *** 1,4 ****
> ! # Copyright 2003 Free Software Foundation, Inc.
>   
>   # This program is free software; you can redistribute it and/or modify
>   # it under the terms of the GNU General Public License as published by
> --- 1,4 ----
> ! # Copyright 2003, 2004 Free Software Foundation, Inc.
>   
>   # This program is free software; you can redistribute it and/or modify
>   # it under the terms of the GNU General Public License as published by
> *************** gdb_reinitialize_dir $srcdir/$subdir
> *** 35,41 ****
>   gdb_load ${binfile}
>   
>   # Verify that we can run the program and that it terminates normally.
> - gdb_test "run" \
> -          ".*Program exited normally\." \
> -          "run program"
>   
> --- 35,47 ----
>   gdb_load ${binfile}
>   
>   # Verify that we can run the program and that it terminates normally.
>   
> + gdb_run_cmd
> + gdb_expect {
> +     -re ".*Program exited normally\.\r\n$gdb_prompt $" {
> +         pass "run program"
> +     }
> +     timeout {
> + 	fail "run program (timeout)"
> +     }
> + }
> 
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer