From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4351 invoked by alias); 2 Feb 2004 20:32:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4314 invoked from network); 2 Feb 2004 20:32:02 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 2 Feb 2004 20:32:02 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Ankjh-00021v-3S; Mon, 02 Feb 2004 15:32:01 -0500 Date: Mon, 02 Feb 2004 20:32:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: gdb-patches@sources.redhat.com, fnf@redhat.com Subject: Re: [RFA] Fix testsuite gdb.base/bang.exp to work with remote targets Message-ID: <20040202203201.GA7318@nevyn.them.org> Mail-Followup-To: Fred Fish , gdb-patches@sources.redhat.com, fnf@redhat.com References: <200402021326.08063.fnf@ninemoons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200402021326.08063.fnf@ninemoons.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00031.txt.bz2 On Mon, Feb 02, 2004 at 01:26:08PM -0700, Fred Fish wrote: > When using a remote target, like SID, you have to "continue" after > a "gdb_load", not "run". Add support for this case. How about gdb_run_cmd? > > 2004-02-02 Fred Fish > > * gdb.base/bang.exp: Handling continuing on remote targets after a > load. > > Index: gdb.base/bang.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/bang.exp,v > retrieving revision 1.1 > diff -u -p -r1.1 bang.exp > --- gdb.base/bang.exp 24 Jun 2003 22:04:06 -0000 1.1 > +++ gdb.base/bang.exp 2 Feb 2004 20:20:04 -0000 > @@ -1,4 +1,4 @@ > -# Copyright 2003 Free Software Foundation, Inc. > +# Copyright 2003, 2004 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > @@ -35,7 +35,10 @@ gdb_reinitialize_dir $srcdir/$subdir > gdb_load ${binfile} > > # Verify that we can run the program and that it terminates normally. > -gdb_test "run" \ > - ".*Program exited normally\." \ > - "run program" > +# For remote targets we simply continue after loading. > > +if [target_info exists use_gdb_stub] { > + gdb_test "continue" ".*Program exited normally\." "run program" > +} else { > + gdb_test "run" ".*Program exited normally\." "run program" > +} > > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer