From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12831 invoked by alias); 27 Jan 2004 22:52:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12823 invoked from network); 27 Jan 2004 22:52:58 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 27 Jan 2004 22:52:58 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Alc4m-0000oP-VI for ; Tue, 27 Jan 2004 17:52:56 -0500 Date: Tue, 27 Jan 2004 22:52:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc Message-ID: <20040127225256.GA3096@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <4016E401.2050001@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4016E401.2050001@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00708.txt.bz2 On Tue, Jan 27, 2004 at 05:19:45PM -0500, Andrew Cagney wrote: > Hello, > > Ref: RFA symtab: Fix for PR c++/1267 ("next" and shared libraries) > http://sources.redhat.com/ml/gdb-patches/2003-07/msg00354.html > > The change unfortunatly broke IRIX 6.5's host compiler which is using > mdebugread :-( That code was looking for a symbol in the absolute > section "*ABS*" but the PR/1267 change was causing *ABS* symbols to be > ignored (find_pc_section didn't return an absolute section). > > Since the underlying problem with PR/1267 was with the frame code > needing a minimal symbol that was in the same section as the frame's PC, > and that code [indirectly] calls lookup_minimal_symbol_by_pc, I moved > the find_pc_section call to that function. > > Tested on i386 GNU/Linux (dwarf 2) with no regressions. > Tested on PPC NetBSD (stabs) with no regressions. > Tested on IRIX and all the warnings, and many failures, disappeared. > See gdb/1519 for how to exercise the bug. > > ok? > Andrew Seems reasonable to me (if a little unintuitive). > 2004-01-27 Andrew Cagney > > * minsyms.c (lookup_minimal_symbol_by_pc): Use find_pc_section > instead of find_pc_mapped_section. > (lookup_minimal_symbol_by_pc_section): If the SECTION is NULL, do > not default to the section containing PC. Fix PR gdb/1519. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer