From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27710 invoked by alias); 23 Jan 2004 22:46:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27701 invoked from network); 23 Jan 2004 22:46:19 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 23 Jan 2004 22:46:19 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AkA4B-0002IY-8S for ; Fri, 23 Jan 2004 17:46:19 -0500 Date: Fri, 23 Jan 2004 22:46:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: {commit: gdb/mi] -stack-list-locals and -var-list-children Message-ID: <20040123224619.GA8624@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <16396.33276.280356.511030@nick.uklinux.net> <20040120054932.GB23548@nevyn.them.org> <20040123170509.GA31156@nevyn.them.org> <16401.36808.499412.201798@nick.uklinux.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <16401.36808.499412.201798@nick.uklinux.net> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00638.txt.bz2 On Fri, Jan 23, 2004 at 09:19:04PM +0000, Nick Roberts wrote: >=20 > > Note that the varobj is out of date. >=20 > If my test is moved after Test: c_variable-5.8 does that work? Assuming t= he > answer is yes, does this count as an obvious fix or does it need approval? That does work. I've checked this in; note you forgot copyright dates. --=20 Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2004-01-23 Daniel Jacobowitz * gdb.mi/mi-var-child.exp: Update copyright year. Move new test after -var-update. Index: testsuite//gdb.mi/mi-var-child.exp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-child.exp,v retrieving revision 1.14 diff -u -p -r1.14 mi-var-child.exp --- testsuite//gdb.mi/mi-var-child.exp 20 Jan 2004 00:54:04 -0000 1.14 +++ testsuite//gdb.mi/mi-var-child.exp 23 Jan 2004 22:44:26 -0000 @@ -1,4 +1,4 @@ -# Copyright (C) 1999, 2000, 2002 Free Software Foundation +# Copyright (C) 1999, 2000, 2002, 2004 Free Software Foundation =20 # This Program Is Free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -827,16 +827,15 @@ mi_gdb_test "-var-update *" \ set line 208 mi_execute_to "exec-step 7" "end-stepping-range" do_children_tests {} {.*v= ar-cmd.c} $line {} "step $line" =20 -mi_gdb_test "-var-list-children --all-values struct_declarations.long_arra= y" \ - "\\^done,numchild=3D\"10\",children=3D\\\[child=3D\{name=3D\"struc= t_declarations.long_array.0\",exp=3D\"0\",numchild=3D\"0\",value=3D\"1234\"= ,type=3D\"long int\"\},child=3D\{name=3D\"struct_declarations.long_array.1\= ",exp=3D\"1\",numchild=3D\"0\",value=3D\"2345\",type=3D\"long int\"\},child= =3D\{name=3D\"struct_declarations.long_array.2\",exp=3D\"2\",numchild=3D\"0= \",value=3D\"3456\",type=3D\"long int\"\},child=3D\{name=3D\"struct_declara= tions.long_array.3\",exp=3D\"3\",numchild=3D\"0\",value=3D\"4567\",type=3D\= "long int\"\},child=3D\{name=3D\"struct_declarations.long_array.4\",exp=3D\= "4\",numchild=3D\"0\",value=3D\"5678\",type=3D\"long int\"\},child=3D\{name= =3D\"struct_declarations.long_array.5\",exp=3D\"5\",numchild=3D\"0\",value= =3D\"6789\",type=3D\"long int\"\},child=3D\{name=3D\"struct_declarations.lo= ng_array.6\",exp=3D\"6\",numchild=3D\"0\",value=3D\"7890\",type=3D\"long in= t\"\},child=3D\{name=3D\"struct_declarations.long_array.7\",exp=3D\"7\",num= child=3D\"0\",value=3D\"8901\",type=3D\"long int\"\},child=3D\{name=3D\"str= uct_declarations.long_array.8\",exp=3D\"8\",numchild=3D\"0\",value=3D\"9012= \",type=3D\"long int\"\},child=3D\{name=3D\"struct_declarations.long_array.= 9\",exp=3D\"9\",numchild=3D\"0\",value=3D\"1234\",type=3D\"long int\"\}\\\]= " \ - "listing of names and values of children" - # Test: c_variable-5.8 # Desc: check that long_array[3-9] changed mi_gdb_test "-var-update *" \ "\\^done,changelist=3D\\\[\{name=3D\"struct_declarations.long_array.3\",i= n_scope=3D\"true\",type_changed=3D\"false\"\},\{name=3D\"struct_declaration= s.long_array.4\",in_scope=3D\"true\",type_changed=3D\"false\"\},\{name=3D\"= struct_declarations.long_array.5\",in_scope=3D\"true\",type_changed=3D\"fal= se\"\},\{name=3D\"struct_declarations.long_array.6\",in_scope=3D\"true\",ty= pe_changed=3D\"false\"\},\{name=3D\"struct_declarations.long_array.7\",in_s= cope=3D\"true\",type_changed=3D\"false\"\},\{name=3D\"struct_declarations.l= ong_array.8\",in_scope=3D\"true\",type_changed=3D\"false\"\},\{name=3D\"str= uct_declarations.long_array.9\",in_scope=3D\"true\",type_changed=3D\"false\= "\}\\\]" \ "update all vars struct_declarations.long_array.3-9 changed" =20 +mi_gdb_test "-var-list-children --all-values struct_declarations.long_arra= y" \ + "\\^done,numchild=3D\"10\",children=3D\\\[child=3D\{name=3D\"struc= t_declarations.long_array.0\",exp=3D\"0\",numchild=3D\"0\",value=3D\"1234\"= ,type=3D\"long int\"\},child=3D\{name=3D\"struct_declarations.long_array.1\= ",exp=3D\"1\",numchild=3D\"0\",value=3D\"2345\",type=3D\"long int\"\},child= =3D\{name=3D\"struct_declarations.long_array.2\",exp=3D\"2\",numchild=3D\"0= \",value=3D\"3456\",type=3D\"long int\"\},child=3D\{name=3D\"struct_declara= tions.long_array.3\",exp=3D\"3\",numchild=3D\"0\",value=3D\"4567\",type=3D\= "long int\"\},child=3D\{name=3D\"struct_declarations.long_array.4\",exp=3D\= "4\",numchild=3D\"0\",value=3D\"5678\",type=3D\"long int\"\},child=3D\{name= =3D\"struct_declarations.long_array.5\",exp=3D\"5\",numchild=3D\"0\",value= =3D\"6789\",type=3D\"long int\"\},child=3D\{name=3D\"struct_declarations.lo= ng_array.6\",exp=3D\"6\",numchild=3D\"0\",value=3D\"7890\",type=3D\"long in= t\"\},child=3D\{name=3D\"struct_declarations.long_array.7\",exp=3D\"7\",num= child=3D\"0\",value=3D\"8901\",type=3D\"long int\"\},child=3D\{name=3D\"str= uct_declarations.long_array.8\",exp=3D\"8\",numchild=3D\"0\",value=3D\"9012= \",type=3D\"long int\"\},child=3D\{name=3D\"struct_declarations.long_array.= 9\",exp=3D\"9\",numchild=3D\"0\",value=3D\"1234\",type=3D\"long int\"\}\\\]= " \ + "listing of names and values of children" =20 # Step over "weird->func_ptr =3D nothing;" set line 211