Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Paul Hilfinger <hilfingr@gnat.com>
Cc: carlton@kealia.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC] Proposed changes in symbol-handling for Ada
Date: Wed, 21 Jan 2004 15:19:00 -0000	[thread overview]
Message-ID: <20040121151916.GB1131@nevyn.them.org> (raw)
In-Reply-To: <20040121105510.3E069F281E@nile.gnat.com>

On Wed, Jan 21, 2004 at 05:55:10AM -0500, Paul Hilfinger wrote:
> 
> > Rather than demangling at startup, we ask each mangled name for a base
> > identifier.  This can be done reasonably efficiently - I hope - I
> > haven't performed measurements yet.  Then, when we search for a symbol,
> > we wildcard for the basename.  We demangle everything with that
> > basename.  If you do a search that doesn't know the basename you
> > have to un-lazy all symbols, of course, but I don't think that's much
> > of a change.
> 
> Daniel,
> 
> At first blush, this sounds like a great idea (at least until someone
> introduces a mangling scheme in which the basename is not a
> substring).  The basename situation for Ada is essentially the same as you
> describe for C++.
> 
> As you may know, the current Ada lookup machinery is separate from (and 
> partially duplicative of) the usual lookup machinery.  There are two
> reasons for this:
> 
> 1. We actually WANT to be able to match on base name alone if the user
>    supplies just a base name.
> 
> 2. We don't include parameter types in mangled names: instead, our
>    basic lookup routine returns a list of all matches, from which we select
>    by parameter type or, if that doesn't work, by giving the user a choice.
> 
> 3. Three; there are three reasons:  we don't store demangled names.
> 
> So, your proposal takes care of 3.  If we could persuade you to
> 
> A. Provide a mode in which you search for the base name (i.e, return 
>    the results of your preliminary sift for base names, skipping the
>    comparison against full demangled name), and
> 
> B. Provide a mode in which you return ALL matches for a name.
> 
> ... why we could clean up all that nasty duplication in the ada-* files and
> join the civilized world.  

OK.  (B) has always been on my todo list; C++ would benefit from it
also.  (A) will require increasing the size of the symbol (because 
I had been planning to overlap the basename information with the
demangled name information using a union, and store the two sets
separately), but I think it's worthwhile.

No promises on timeline, since I'm working on several other projects
right now, but I'll try to pull this together.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-01-21 15:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-08 22:55 Interactions of symbol-lookup with language Paul N. Hilfinger
2003-11-10 17:07 ` David Carlton
2004-01-20 10:16   ` [RFC] Proposed changes in symbol-handling for Ada Paul Hilfinger
2004-01-20 15:01     ` Daniel Jacobowitz
2004-01-21 10:55       ` Paul Hilfinger
2004-01-21 15:19         ` Daniel Jacobowitz [this message]
2004-01-23 21:08           ` Andrew Cagney
2004-01-20 23:05     ` David Carlton
2004-01-21 11:22       ` Paul Hilfinger
2004-01-21 16:49         ` David Carlton
2004-01-21 18:50           ` Daniel Jacobowitz
2003-11-11  1:23 ` Interactions of symbol-lookup with language Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040121151916.GB1131@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=carlton@kealia.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hilfingr@gnat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox