From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] target.c: eliminate one use of DEPRECATED_REGISTER_SIZE
Date: Mon, 19 Jan 2004 16:52:00 -0000 [thread overview]
Message-ID: <20040119095230.780b83a7@saguaro> (raw)
In-Reply-To: <4001A0BC.6050809@gnu.org>
On Sun, 11 Jan 2004 14:15:08 -0500
Andrew Cagney <cagney@gnu.org> wrote:
> > default_region_size_ok_for_hw_watchpoint (int byte_count)
> > {
> > - return (byte_count <= DEPRECATED_REGISTER_SIZE);
> > + return (byte_count <= (TARGET_PTR_BIT / TARGET_CHAR_BIT));
> > }
> >
> Ok, but with `TYPE_LENGTH (builtin_type_void_{code/data}_ptr)'. Here I
> believe that the data pointer would be more correct.
Okay.
Committed. Here's what went in:
* target.c (default_region_size_ok_for_hw_watchpoint): Compare
the region size against the size of a pointer, not the size of
a register as given by DEPRECATED_REGISTER_SIZE.
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.69
diff -u -p -r1.69 target.c
--- target.c 19 Jan 2004 01:20:11 -0000 1.69
+++ target.c 19 Jan 2004 16:45:48 -0000
@@ -1360,7 +1360,7 @@ find_default_create_inferior (char *exec
static int
default_region_size_ok_for_hw_watchpoint (int byte_count)
{
- return (byte_count <= DEPRECATED_REGISTER_SIZE);
+ return (byte_count <= TYPE_LENGTH (builtin_type_void_data_ptr));
}
static int
prev parent reply other threads:[~2004-01-19 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-09 3:20 Kevin Buettner
2004-01-11 19:15 ` Andrew Cagney
2004-01-19 16:52 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040119095230.780b83a7@saguaro \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox