From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27930 invoked by alias); 18 Jan 2004 22:52:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27893 invoked from network); 18 Jan 2004 22:52:55 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 18 Jan 2004 22:52:55 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AiLmo-0002Dr-KM for ; Sun, 18 Jan 2004 17:52:54 -0500 Date: Sun, 18 Jan 2004 22:52:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] Reorganize osabi.c:generic_elf_osabi_sniff_abi_tag_sections() Message-ID: <20040118225254.GA8516@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <200401182040.i0IKeeMu008703@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200401182040.i0IKeeMu008703@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00484.txt.bz2 On Sun, Jan 18, 2004 at 09:40:40PM +0100, Mark Kettenis wrote: > + /* ...and check it. */ > + gdb_assert (notesz <= MAX_NOTESZ); > + if (notesz > bfd_section_size (abfd, sect)) > + return 0; I'd rather not add assertions based on the input file. Can we complain and fail instead? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer