From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: Import a readline bugfix
Date: Sun, 18 Jan 2004 19:50:00 -0000 [thread overview]
Message-ID: <20040118195017.GA5434@nevyn.them.org> (raw)
I was working on an ornery completion bug this morning and stumbled across:
http://ftp.gnu.org/gnu/readline/readline-4.3-patches/readline43-001
This patch fixes an infinite loop in readline on hitting certain keys - on
my terminal one of them is shift-delete, which I hit by accident pretty
frequently. OK to commit this?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
READLINE PATCH REPORT
=====================
Readline-Release: 4.3
Patch-ID: readline43-001
Bug-Reported-by: Thierry Vignaud <tvignaud@mandrakesoft.com>
Bug-Reference-ID: <m2wurdqvo0.fsf@vador.mandrakesoft.com> (bug-readline)
Bug-Reference-URL:
Bug-Description:
Pressing certain key sequences causes an infinite loop in _rl_dispatch_subseq
with the `key' argument set to 256. This eventually causes bash to exceed
the stack size limit and crash with a segmentation violation.
Patch:
*** ../readline-4.3/bind.c Thu Jan 24 11:15:52 2002
--- bind.c Wed Jul 31 09:11:18 2002
***************
*** 312,316 ****
and the function bound to `a' to be executed when the user
types `abx', leaving `bx' in the input queue. */
! if (k.function /* && k.type == ISFUNC */)
{
map[ANYOTHERKEY] = k;
--- 312,316 ----
and the function bound to `a' to be executed when the user
types `abx', leaving `bx' in the input queue. */
! if (k.function && ((k.type == ISFUNC && k.function != rl_do_lowercase_version) || k.type == ISMACR))
{
map[ANYOTHERKEY] = k;
next reply other threads:[~2004-01-18 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-18 19:50 Daniel Jacobowitz [this message]
2004-01-29 23:34 ` Elena Zannoni
2004-01-29 23:38 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040118195017.GA5434@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox