From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28067 invoked by alias); 18 Jan 2004 15:08:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28052 invoked from network); 18 Jan 2004 15:07:59 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 18 Jan 2004 15:07:59 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i0IF7keT007613; Sun, 18 Jan 2004 16:07:46 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i0IF7kBd053656; Sun, 18 Jan 2004 16:07:46 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i0IF7jWv053653; Sun, 18 Jan 2004 16:07:45 +0100 (CET) Date: Sun, 18 Jan 2004 15:08:00 -0000 Message-Id: <200401181507.i0IF7jWv053653@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <40095693.90007@gnu.org> (message from Andrew Cagney on Sat, 17 Jan 2004 10:36:51 -0500) Subject: Re: [patch/rfc] Give decr pc after break a default of zero References: <40071B7A.3080106@gnu.org> <200401161623.i0GGNsEF000356@elgar.kettenis.dyndns.org> <40095693.90007@gnu.org> X-SW-Source: 2004-01/txt/msg00471.txt.bz2 Date: Sat, 17 Jan 2004 10:36:51 -0500 From: Andrew Cagney > Removing the set-to-zero for Neutrino would be wrong; it is essential > that we override the i386 default. Personally I think the "NOTE" form > of the comment you added isn't really appropriate. I'd prefer > something like: > > /* Neutrino rewinds to look more normal, so we have to override the > i386 default value. */ > > Since that explains why we override the i386 default value. It's > probably a matter of taste, but I'd appreciate if you changes it that > way. I've changed it to: ``Neutrino rewinds to look more normal. Need to override the i386 default which is [unfortunatly] to decrement the PC.'' Make's it clear which is "wrong" :-) committed, Thanks! Mark