From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1796 invoked by alias); 16 Jan 2004 17:32:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1751 invoked from network); 16 Jan 2004 17:32:36 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 16 Jan 2004 17:32:36 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AhXpj-0001yD-Kh; Fri, 16 Jan 2004 12:32:35 -0500 Date: Fri, 16 Jan 2004 17:32:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com, Andrew Cagney Subject: Re: RFA/ARM: Switch mode when setting PC Message-ID: <20040116173235.GA7498@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Andrew Cagney References: <20040116035402.GA3215@nevyn.them.org> <40077A12.5040306@gnu.org> <20040116141040.GA8134@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040116141040.GA8134@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00419.txt.bz2 On Fri, Jan 16, 2004 at 09:10:40AM -0500, Daniel Jacobowitz wrote: > > The ari contains this yellow card: > > > > write pc > > Replace write_pc() with get_frame_base_address or get_frame_id; at > > present the inferior function call code still uses this when doing a > > DECR_PC_AFTER_BREAK > > > > the concern is with the way write_pc is being called to perform two > > different operations: > > > > - decrement the pc just after the target stops > > Arrrg! > > - jump to a specific address > > As with an inferior function call or jump. > > > > I think it would be better to have two methods so that it's clear that > > this case only applies when doing a jump. > > Well, it'd be better to rip out the current DECR_PC_AFTER_BREAK and > handle it completely within the four (roughly) affected targets, > thereby removing the overloading of write_pc. IMVHO. Hi Andrew, Is this patch OK (write_pc isn't deprecated yet!)? Cleaning up the existing DECR_PC_AFTER_BREAK handling is going to be a touchy job, and I don't really want to try it today :) I'll try to look into it later, though. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer