From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [commit/mips] For elf_flags, use the previous arch
Date: Thu, 08 Jan 2004 14:21:00 -0000 [thread overview]
Message-ID: <20040108142146.GA17207@nevyn.them.org> (raw)
In-Reply-To: <3FFCE551.30009@gnu.org>
On Thu, Jan 08, 2004 at 12:06:25AM -0500, Andrew Cagney wrote:
> Hello,
>
> This fixes a subtle edge case. Given the sequence:
>
> (gdb) file foo
> (gdb) set mipsfpu none
> (gdb) file foo
>
> An extra, unnecessary arch was being created after the second "file foo".
After the "file foo"? I'm confused as to how this case can trigger,
since we ought to have info.abfd at that point, right?
> 2004-01-07 Andrew Cagney <cagney@redhat.com>
>
> * mips-tdep.c (mips_gdbarch_init): Set elf_flags to the previous
> architecture's elf flags (when available).
>
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.267
> diff -u -r1.267 mips-tdep.c
> --- mips-tdep.c 8 Jan 2004 04:57:38 -0000 1.267
> +++ mips-tdep.c 8 Jan 2004 05:02:23 -0000
> @@ -5688,6 +5688,8 @@
> /* First of all, extract the elf_flags, if available. */
> if (info.abfd && bfd_get_flavour (info.abfd) == bfd_target_elf_flavour)
> elf_flags = elf_elfheader (info.abfd)->e_flags;
> + else if (arches != NULL)
> + elf_flags = gdbarch_tdep (arches->gdbarch)->elf_flags;
> else
> elf_flags = 0;
> if (gdbarch_debug)
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-01-08 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 5:06 Andrew Cagney
2004-01-08 14:21 ` Daniel Jacobowitz [this message]
2004-01-08 17:55 ` Andrew Cagney
2004-01-08 17:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040108142146.GA17207@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox