From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14608 invoked by alias); 7 Jan 2004 00:27:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14484 invoked from network); 7 Jan 2004 00:26:59 -0000 Received: from unknown (HELO bubble.modra.org) (144.136.188.60) by sources.redhat.com with SMTP; 7 Jan 2004 00:26:59 -0000 Received: by bubble.modra.org (Postfix, from userid 500) id B8FCB2C837; Wed, 7 Jan 2004 10:56:57 +1030 (CST) Date: Wed, 07 Jan 2004 00:27:00 -0000 From: Alan Modra To: Geoff Keating Cc: dje@watson.ibm.com, gcc-patches@gcc.gnu.org, cagney@gnu.org, kettenis@chello.nl, gdb-patches@sources.redhat.com, Ulrich.Weigand@de.ibm.com Subject: Re: Incorrect DWARF-2 register numbers on PPC64? Message-ID: <20040107002657.GE2533@bubble.modra.org> Mail-Followup-To: Geoff Keating , dje@watson.ibm.com, gcc-patches@gcc.gnu.org, cagney@gnu.org, kettenis@chello.nl, gdb-patches@sources.redhat.com, Ulrich.Weigand@de.ibm.com References: <200312182258.hBIMwgT25422@makai.watson.ibm.com> <200312201527.hBKFRHgI000712@elgar.kettenis.dyndns.org> <3FF5A069.1040306@gnu.org> <200401022317.i02NHQBR001191@desire.geoffk.org> <20040106152710.GB2533@bubble.modra.org> <200401061807.i06I7Uu7015387@desire.geoffk.org> <200401061809.i06I9vT26150@makai.watson.ibm.com> <200401062208.i06M8fT34484@makai.watson.ibm.com> <200401062234.i06MYT01015475@desire.geoffk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200401062234.i06MYT01015475@desire.geoffk.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-01/txt/msg00153.txt.bz2 On Tue, Jan 06, 2004 at 02:34:29PM -0800, Geoff Keating wrote: > > Date: Tue, 06 Jan 2004 17:08:40 -0500 > > From: David Edelsohn > > > >>>>> Geoff Keating writes: > > > > Geoff> Then, doesn't this patch break stabs under ELF? > > > > The patch only maps the register number for DWARF2_DEBUG: > > > > + if (regno <= 63 || write_symbols != DWARF2_DEBUG) > > + return regno; > > > > However, there is no reason to waste the time computing a no-op > > transformation on targets that do not have a choice of Dwarf2 debugging. > > OK. It'd probably be better to have this at the toplevel and an undef > for AIX, since Darwin will one day have DWARF, but that can be done > later. I originally put the DBX_REGISTER_NUMBER define in rs6000.h, but quickly found that was #undef'd by config/svr4.h, which is included later. If you want the define in rs6000.h, that can be done by either removing the #undef in svr4.h, or including rs6000.h after svr4.h. I've done the work to verify that you can include rs6000.h later by adding a few #undefs in rs6000.h, and defining SIZE_TYPE in rs6000/sysv4.h (in fact, I wrote the patch that way in the first instance), but decided that resulted in a much more intrusive patch. -- Alan Modra IBM OzLabs - Linux Technology Centre