From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17330 invoked by alias); 6 Jan 2004 11:56:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17323 invoked from network); 6 Jan 2004 11:56:10 -0000 Received: from unknown (HELO mail2.astercity.net) (212.76.33.39) by sources.redhat.com with SMTP; 6 Jan 2004 11:56:10 -0000 Received: from dixie.localdomain (52-tor-2.acn.waw.pl [62.121.69.52]) by mail2.astercity.net (sendmail) with ESMTP id 2F68D330E3E; Tue, 6 Jan 2004 12:56:10 +0100 (CET) Received: by dixie.localdomain (Postfix, from userid 500) id A2C051138DA; Tue, 6 Jan 2004 12:56:46 +0100 (CET) Date: Tue, 06 Jan 2004 11:56:00 -0000 From: =?iso-8859-2?B?UGF3ZcWC?= Ostrowski To: Michael Snyder Cc: Pawel Ostrowski , gdb-patches@sources.redhat.com Subject: Re: [PATCH] segv fix when eof is typed in actions Message-ID: <20040106115646.GA12624@dixie.localdomain> References: <20040102021243.GA28939@dixie.localdomain> <3FFA0BD6.70805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3FFA0BD6.70805@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-01/txt/msg00135.txt.bz2 Dnia Mon, Jan 05, 2004 at 05:13:58PM -0800, Michael Snyder napisa³(a): > >GDB (snapshot 20031230) segfaults on the following script (and on any > >program being debugged: int main() {return 0;} is enough): > > > >trace main > >actions 1 > > > > > >I have found out that typing EOF when editing tracepoint actions > >causes gdb to segv. The segv is caused by dereferencing twice line > >parameter (**line), when *line is NULL. I have added check for this > >case to validate_actionline() in tracepoint.c, so it now ends actions > >editing (just like you would have typed "end" instead of EOF). > > > >Some details of my configuration: > >- gdb versions: 6.0, 20031230 snapshot, both compiled with gcc 3.3.2 > >- uname -rmpo: 2.6.0 i686 AMD_Athlon(tm)_XP_1500+ PLD Linux > > Approved -- want me to check it in for you? Yes, please. I will be obliged for helping me in this matter. -- Pasza