From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-29633-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 13239 invoked by alias); 5 Jan 2004 23:01:20 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13213 invoked from network); 5 Jan 2004 23:01:19 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144)
  by sources.redhat.com with SMTP; 5 Jan 2004 23:01:19 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i05N1Dsd000304;
	Tue, 6 Jan 2004 00:01:13 +0100 (CET)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i05N1CD5001493;
	Tue, 6 Jan 2004 00:01:12 +0100 (CET)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i05N1CM0001490;
	Tue, 6 Jan 2004 00:01:12 +0100 (CET)
Date: Mon, 05 Jan 2004 23:01:00 -0000
Message-Id: <200401052301.i05N1CM0001490@elgar.kettenis.dyndns.org>
From: Mark Kettenis <kettenis@chello.nl>
To: cagney@gnu.org
CC: gdb-patches@sources.redhat.com
In-reply-to: <3FF9DDBB.9000108@gnu.org> (message from Andrew Cagney on Mon, 05
	Jan 2004 16:57:15 -0500)
Subject: Re: [PATCH] Don't try to unwind the PC in frame.c:get_prev_frame()
References: <200401052033.i05KXcxx000617@elgar.kettenis.dyndns.org> <3FF9DDBB.9000108@gnu.org>
X-SW-Source: 2004-01/txt/msg00118.txt.bz2

   Date: Mon, 05 Jan 2004 16:57:15 -0500
   From: Andrew Cagney <cagney@gnu.org>

   > Andrew, I saw no use for retaining some of the commentd, so I delete
   > the thing completely.

   Can just you add a -ve comment stating why a test for PC==0 does not 
   belong in that function?  I'm pretty much certain that someone will 
   eventually try to re-add a very similar test (via inside_entry_func for 
   instance).

Well, I just added a regression test, shouldn't that be enough?

(You just reminded me that I should remove the PC == 0 check from
inside_entry_func too).

Mark