From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8342 invoked by alias); 3 Jan 2004 15:09:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8335 invoked from network); 3 Jan 2004 15:09:24 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 3 Jan 2004 15:09:24 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i03F9BAA000762; Sat, 3 Jan 2004 16:09:11 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i03F9BwK026208; Sat, 3 Jan 2004 16:09:11 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i03F9BXD026205; Sat, 3 Jan 2004 16:09:11 +0100 (CET) Date: Sat, 03 Jan 2004 15:09:00 -0000 Message-Id: <200401031509.i03F9BXD026205@elgar.kettenis.dyndns.org> From: Mark Kettenis To: brobecker@gnat.com CC: ac131313@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <20040103150107.GY820@gnat.com> (message from Joel Brobecker on Sat, 3 Jan 2004 16:01:07 +0100) Subject: Re: [RFA] infrun.c:handle_inferior_event() tiny simplification (was "Re: [RFA/patch] handle_inferior_event() extract some code into a separate function") References: <20031219144323.GL826@gnat.com> <3FF59C76.3000902@gnu.org> <20040103115203.GU820@gnat.com> <200401031251.i03CpAwn025849@elgar.kettenis.dyndns.org> <20040103150107.GY820@gnat.com> X-SW-Source: 2004-01/txt/msg00054.txt.bz2 Date: Sat, 3 Jan 2004 16:01:07 +0100 From: Joel Brobecker > infrun.c: In function `handle_inferior_event': > infrun.c:1337: warning: `real_stop_pc' might be used uninitialized in this function Thanks to Mark, I looked closer to this variable. It turns out that this variable is very locally used in two blocks of the function, vis: [...] I agree with your analysis. So the real mistake I made was to make real_stop_pc a parameter of the new function I introduced. It should have been a local variable to that function. Here is what I suggest: 1. A patch to makes it more obvious that this variable is only locally used by defining it only inside these if blocks. Patch attached. 2. Send an updated version of the patch I backed out where real_stop_pc is local variable to the new function, rather than a parameter (that was completely foolish since we don't even use the value that was passed and was not set in any case) Here is the first patch: 2004-01-03 J. Brobecker * infrun.c (handle_inferior_event): Move the declaration of real_stop_pc inside the if blocks where it is used. OK to apply? Tested on x86-linux with GCC 3.2.3, no warning, and no regression. Sounds great to me. Consider the other patch pre-approved. Mark