Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: carlton@kealia.com, gdb-patches@sources.redhat.com
Subject: Re: [patch/testsuite/cp] classes.exp: rewrite
Date: Wed, 31 Dec 2003 14:06:00 -0000	[thread overview]
Message-ID: <20031231140645.GB31238@nevyn.them.org> (raw)
In-Reply-To: <20031231111559.B0A5B4B35A@berman.michael-chastain.com>

On Wed, Dec 31, 2003 at 06:15:59AM -0500, Michael Chastain wrote:
> classes.exp has a problem with the new default gcc abi, gcc abi 2.
> I started fixing the problem and ended up rewriting most of the file.
> 
> Here's a reminder:
> 
>   /* gcc abi 1 */
>   class Whatever
>   {
>     public:
>       Whatever & operator=(const Whatever &);
>       Whatever(const Whatever &);
>       Whatever();
>       int method ();
>   };
> 
>   /* gcc abi 2*/
>   class Whatever
>   {
>     public:
>       int method ();
>       Whatever & operator=(const Whatever &);
>       Whatever(const Whatever &);
>       Whatever();
>   };
> 
> That is, with the new ABI, synthetic methods appear after the
> user-defined methods rather than before.  This really is an ABI change:
> if a class has a synthetic virtual destructor, the vtable will be
> ordered differently than it was before.
> 
> gdb prints the synthetic methods for stabs+, but not dwarf-2.
> There are about ten test scripts that get hit by this and need
> new patterns.

If we had classes with explicit destructors, you'd see the change in
both stabs and dwarf2, I believe.  I'm not quite sure about that
though.  Hmm, maybe not, maybe only the implicit one was affected.

> This is wrong; conversion operators do not have types.  This bug was
> also in gdb 6.0.  I need to KFAIL this before I commit.

It's a bug in GDB.  There's already a PR somewhere - I think it's
referenced in templates.exp.  I'll be fixing it in a little while.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


      reply	other threads:[~2003-12-31 14:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-31 11:16 Michael Elizabeth Chastain
2003-12-31 14:06 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031231140645.GB31238@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=carlton@kealia.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox