From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3852 invoked by alias); 17 Dec 2003 20:13:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3831 invoked from network); 17 Dec 2003 20:13:38 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Dec 2003 20:13:38 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AWi36-0008SB-Qx for ; Wed, 17 Dec 2003 15:13:36 -0500 Date: Wed, 17 Dec 2003 20:13:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA]: add reason code and silent flag to decode_line_1 Message-ID: <20031217201335.GA32442@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3FD4F5D8.4000207@redhat.com> <3FD5000E.4000009@redhat.com> <3FD63D92.40808@redhat.com> <16352.45827.598227.492906@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16352.45827.598227.492906@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-12/txt/msg00416.txt.bz2 On Wed, Dec 17, 2003 at 02:48:19PM -0500, Elena Zannoni wrote: > J. Johnston writes: > > David, here is the updated patch based on your suggestion. It is definitely > > cleaner in the short-term. > > > > 2003-12-09 Jeff Johnston > > > > * linespec.h (decode_line_1): Add new not_found_ptr parameter. > > * linespec.c (decode_line_1): Add new parameter. Pass on > > new parameter to decode_variable and symtab_from_filename > > functions. > > (decode_variable): Add new not_found_ptr parameter. Throw exception > > rather than failing if the not_found_ptr is non-null and the > > function is not found. > > (symtab_from_filename): Add new not_found_ptr parametr. Throw exception > > rather than failing if the not_found_ptr is non-null and the > > source file is not found. > > * breakpoint.c: Change all callers of decode_line_1 to add default > > extra parameter for decode_line_1 calls. > > * tracepoint.c: Ditto. > > * cli/cli-cmds.c: Ditto. > > > The linespec.c/.h part is approved. Thanks - Jeff, with that approval I believe the rest of this patch is obvious. Eagerly awaiting the next bits. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer