From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28578 invoked by alias); 17 Dec 2003 06:22:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28538 invoked from network); 17 Dec 2003 06:22:46 -0000 Received: from unknown (HELO fred.ninemoons.com) (68.14.214.217) by sources.redhat.com with SMTP; 17 Dec 2003 06:22:46 -0000 Received: from fred.ninemoons.com (fred.ninemoons.com [127.0.0.1]) by fred.ninemoons.com (8.12.8/8.12.8) with ESMTP id hBH6Mjmr003115; Tue, 16 Dec 2003 23:22:45 -0700 Received: from localhost (localhost [[UNIX: localhost]]) by fred.ninemoons.com (8.12.8/8.12.8/Submit) id hBH6MjCR003113; Tue, 16 Dec 2003 23:22:45 -0700 From: Fred Fish Reply-To: fnf@ninemoons.com To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Remove some hardwired assumptions about register sets Date: Wed, 17 Dec 2003 06:22:00 -0000 User-Agent: KMail/1.5 Cc: fnf@ninemoons.com References: <200312170614.hBH6Ebtl003033@fred.ninemoons.com> In-Reply-To: <200312170614.hBH6Ebtl003033@fred.ninemoons.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200312162322.45004.fnf@ninemoons.com> X-SW-Source: 2003-12/txt/msg00404.txt.bz2 > Comments? OK, I get to offer the first comment. :-) > ! num_mips_processor_regs = sizeof (mips_irix_reg_names) / sizeof (char *); These should use ARRAY_SIZE(). -Fred