From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5363 invoked by alias); 16 Dec 2003 19:23:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5327 invoked from network); 16 Dec 2003 19:23:07 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 16 Dec 2003 19:23:07 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AWKmh-00022U-Fh for ; Tue, 16 Dec 2003 14:23:07 -0500 Date: Tue, 16 Dec 2003 19:23:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [rfa] add DMGL_PARAMS (was: new demangler) Message-ID: <20031216192307.GA7798@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031216053022.GA28127@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-12/txt/msg00394.txt.bz2 On Tue, Dec 16, 2003 at 08:54:57AM -0800, David Carlton wrote: > On Tue, 16 Dec 2003 00:30:22 -0500, Daniel Jacobowitz said: > > On Mon, Dec 15, 2003 at 03:38:28PM -0800, David Carlton wrote: > > >> Okay; I'll just stick in the DMGL_PARAMS for now, then - my tests > >> start passing again with that change. (Or I could rewrite the code > >> that parses the output to not look for parentheses, I suppose.) > > > Do the former for now. > > The latter actually should be easy enough given the parsing > functionality that's already in cp-support.c, but I have no objection > to the former, which I present here. Is it okay for mainline? Tested > on i686-pc-linux-gnu, GCC 3.2, DWARF 2; no regressions. (No tests, > but it's necessary for my current patch awaiting approval to work > properly.) > > David Carlton > carlton@kealia.com > > 2003-12-16 David Carlton > > * cp-support.c (class_name_from_physname): Add DMGL_PARAMS. > (method_name_from_physname): Ditto. Yes, this is fine. Thanks! -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer