From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12014 invoked by alias); 11 Dec 2003 14:14:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12000 invoked from network); 11 Dec 2003 14:14:14 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (212.157.227.203) by sources.redhat.com with SMTP; 11 Dec 2003 14:14:14 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id E359647D62; Thu, 11 Dec 2003 09:14:16 -0500 (EST) Date: Thu, 11 Dec 2003 14:14:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] observer tests & GCC 3.4 Message-ID: <20031211141416.GB1494@gnat.com> References: <200312111355.hBBDtFE7000504@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200312111355.hBBDtFE7000504@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.4i X-SW-Source: 2003-12/txt/msg00316.txt.bz2 > The compiler is getting too smart for its own good again. At the end > of observer.c, we have a bit of code that used in the > gdb.gdb/observer.exp testcase. Since the variables and functions are > declared static, the compiler simply optimizes these out. The > attached patch fixes this. Objections? Humph. I don't know of any other way to stop GDB from optimizing them out, so no objection from me. > Index: ChangeLog > from Mark Kettenis > > * observer.c (observer_test_first_observer, > observer_test_second_observer, observer_test_third_observer): > Don't define as `static'. > (observer_test_first_notification_function, > observer_test_second_notification_function, > observer_test_third_notification_function): Likewise. -- Joel