From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32542 invoked by alias); 9 Dec 2003 06:52:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32517 invoked from network); 9 Dec 2003 06:52:49 -0000 Received: from unknown (HELO barry.mail.mindspring.net) (207.69.200.25) by sources.redhat.com with SMTP; 9 Dec 2003 06:52:49 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by barry.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1ATbjf-0005yB-00; Tue, 09 Dec 2003 01:52:43 -0500 Received: by berman.michael-chastain.com (Postfix, from userid 502) id 178254B412; Tue, 9 Dec 2003 01:52:41 -0500 (EST) To: fnf@ninemoons.com Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com Message-Id: <20031209065241.178254B412@berman.michael-chastain.com> Date: Tue, 09 Dec 2003 06:52:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2003-12/txt/msg00273.txt.bz2 It works for me. My before-and-after tests came out clean again; all the copyright dates look good; and the comment about the separate file is exactly what I wanted. Endorsed for approval. (I'm trying to come up with some word that means "I don't have approval authority but I'll vouch for this patch" ... "endorsed"? "recommended"?) Michael C === 2003-12-07 Fred Fish * gdb.base/break.c (marker1, marker2, marker3, marker4): Move functions to break1.c and leave prototypes behind. Add more "set breakpoint NN here" comments. * gdb.base/break1.c: New file. * gdb.base/break.exp: Handle compiling test case from multiple source files and change source file references as needed. * gdb.base/completion.exp: Ditto. * gdb.base/condbreak.exp: Ditto. * gdb.base/define.exp: Ditto. * gdb.base/ena-dis-br.exp: Ditto. * gdb.base/info-proc.exp: Ditto. * gdb.base/maint.exp: Ditto. * gdb.base/until.exp: Ditto. * gdb.base/condbreak.exp: Use bp_locationNN variables instead of hardcoded line numbers. * gdb.base/define.exp: Ditto. * gdb.base/ena-dis-br.exp: Ditto. * gdb.base/maint.exp: Ditto. * gdb.base/until.exp: Ditto. * gdb.base/completion.exp: Use "break1" for completion tests since "break" is no longer a unique prefix.