Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [PATCH] S/390 DWARF-2 CFI frame support
Date: Fri, 05 Dec 2003 00:49:00 -0000	[thread overview]
Message-ID: <20031205004756.GA18170@redhat.com> (raw)
In-Reply-To: <200312042009.VAA07733@faui1d.informatik.uni-erlangen.de>

On Thu, Dec 04, 2003 at 09:09:12PM +0100, Ulrich Weigand wrote:
>   To fix this, I suggest the following.  What GCC assumes to happen
>   when it leaves a register unspecified in the CFI depends on whether
>   the register is call-saved or call-clobbered according to the 
>   target's ABI.  If it is call-saved (and unspecified), the function
>   doesn't save/restore it because it does not in fact ever modify it.
>   Thus, in this case the debugger should copy the value from the 
>   inner frame.  If it is call-clobbered (those will always be left
>   unspecified), it should be assumed undefined.

This is wrong.  The debugger should just assume *all* registers
that are not explicitly saved are preserved.  In the case of
call-clobbered registers, you just won't *know* that they are
actually dead.  But so what?  This is no worse than not having
location list information that tells you that a value is dead
after its register gets re-used for something else.

However, when I made this argument before, it wasn't good enough
for some people, and they added the annoying warning anyway.


r~


  parent reply	other threads:[~2003-12-05  0:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-04 20:09 Ulrich Weigand
2003-12-04 22:47 ` Jim Blandy
2003-12-05  0:49 ` Richard Henderson [this message]
2003-12-05  1:04   ` Andrew Cagney
2003-12-05  1:44     ` Richard Henderson
2003-12-05  2:03   ` Ulrich Weigand
2003-12-05  2:11     ` Richard Henderson
2003-12-05  2:16       ` Ulrich Weigand
2003-12-05  2:13     ` Daniel Jacobowitz
2003-12-05  2:19       ` Ulrich Weigand
2003-12-05 16:02 ` Andrew Cagney
2003-12-05 17:54   ` Ulrich Weigand
2003-12-10 17:14   ` Andrew Cagney
2003-12-10 18:52     ` Ulrich Weigand
2003-12-12 17:43     ` Mark Kettenis
2003-12-13 15:32       ` Ulrich Weigand
2003-12-14 15:23         ` Mark Kettenis
2003-12-14 16:40           ` Andrew Cagney
2003-12-14 17:16             ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031205004756.GA18170@redhat.com \
    --to=rth@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=uweigand@de.ibm.com \
    --cc=weigand@i1.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox