Re: [RFA] stabs: remember types that cross reference another type

[Joel Brobecker <brobecker@gnat.com>]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

> yep

Great!

For the record, here is the patch I ended up committing.

2003-12-04  J. Brobecker  <brobecker@gnat.com>

        * stabsread.c (read_type): Save a reference to types that are defined
        as cross references to other types.

Thanks,
-- 
Joel

[-- Attachment #2: stabsread.c.diff --]
[-- Type: text/plain, Size: 1106 bytes --]

Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.68
diff -u -p -r1.68 stabsread.c
--- stabsread.c	15 Nov 2003 21:49:30 -0000	1.68
+++ stabsread.c	5 Dec 2003 00:31:35 -0000
@@ -1564,11 +1564,9 @@ again:
 	  *pp = from + 1;
 	}
 
-	/* Now check to see whether the type has already been
-	   declared.  This was written for arrays of cross-referenced
-	   types before we had TYPE_CODE_TARGET_STUBBED, so I'm pretty
-	   sure it is not necessary anymore.  But it might be a good
-	   idea, to save a little memory.  */
+        /* If this type has already been declared, then reuse the same
+           type, rather than allocating a new one.  This saves some
+           memory.  */
 
 	for (ppt = file_symbols; ppt; ppt = ppt->next)
 	  for (i = 0; i < ppt->nsyms; i++)
@@ -1582,6 +1580,8 @@ again:
 		{
 		  obstack_free (&objfile->type_obstack, type_name);
 		  type = SYMBOL_TYPE (sym);
+	          if (typenums[0] != -1)
+	            *dbx_lookup_type (typenums) = type;
 		  return type;
 		}
 	    }